Currently, we add the author name for all PRs that have been merged. However, getting something merged always requires at least two roles: an author and a reviewer.
In the spirit of surfacing more credit for the work people do around pull requests, we could add the option of including reviewer name with each PR item. For example:
Doing something cool #119 (@authorname, reviewed by @reviewer1, @reviewer2)
Implementation
I think we're already grabbing PR reviewer information here:
|
reviews_query = """\ |
|
reviews(last: 100) { |
|
edges { |
|
node { |
|
authorAssociation |
|
author { |
|
login |
|
} |
|
} |
|
} |
|
} |
|
""" |
And somewhere around here I think we'd need to add the reviewer information, maybe behind a feature flag:
|
for kind, info in prs.items(): |
Currently, we add the author name for all PRs that have been merged. However, getting something merged always requires at least two roles: an author and a reviewer.
In the spirit of surfacing more credit for the work people do around pull requests, we could add the option of including reviewer name with each PR item. For example:
Implementation
I think we're already grabbing PR reviewer information here:
github-activity/github_activity/graphql.py
Lines 27 to 38 in a9d85f4
And somewhere around here I think we'd need to add the
reviewerinformation, maybe behind a feature flag:github-activity/github_activity/github_activity.py
Line 656 in a9d85f4