test: add pattern repository resolution coverage

Author: haasonsaas

TODO.md

@@ -82,7 +82,7 @@ This roadmap is derived from deep research into Greptile's public docs, blog, MC
 46. [ ] Support document-backed context ingestion for design docs, RFCs, and runbooks.
 47. [ ] Add explicit "intent mismatch" review checks comparing PR changes to ticket acceptance criteria.
 48. [ ] Add review artifacts that show which external context sources influenced a finding.
-49. [ ] Add tests for pattern repository resolution across local paths, Git URLs, and broken sources.
+49. [x] Add tests for pattern repository resolution across local paths, Git URLs, and broken sources.
 50. [ ] Add analytics on which context sources actually improve acceptance and fix rates.
 
 ## 6. Review UX and Workflow Integration
@@ -174,4 +174,5 @@ This roadmap is derived from deep research into Greptile's public docs, blog, MC
 - [x] Add Analytics JSON/CSV exports covering review quality, lifecycle, and reinforcement metrics.
 - [x] Add learned-rules, attention-gap, and rejected-pattern analytics API endpoints for automation consumers.
 - [x] Add a PR re-review API that reuses stored review metadata and posting policy.
+- [x] Add pattern repository resolution coverage for repo-local directories, Git sources, and broken-source skips.
 - [ ] Commit and push each validated checkpoint before moving to the next epic.

src/review/context_helpers/pattern_repositories.rs

@@ -16,7 +16,12 @@ pub use run::resolve_pattern_repositories;
 
 #[cfg(test)]
 mod tests {
+    use std::cell::RefCell;
+
+    use crate::config;
+
     use super::git::{is_git_source, is_safe_git_url};
+    use super::run::resolve_pattern_repositories_with;
 
     #[test]
     fn test_is_git_source_https() {
@@ -81,4 +86,80 @@ mod tests {
     fn test_is_safe_git_url_rejects_http_without_git_suffix() {
         assert!(!is_safe_git_url("http://example.com/repo"));
     }
+
+    #[test]
+    fn test_resolve_pattern_repositories_accepts_repo_relative_local_paths() {
+        let tempdir = tempfile::tempdir().unwrap();
+        let repo_root = tempdir.path();
+        let local_repo = repo_root.join("patterns/local-rules");
+        std::fs::create_dir_all(&local_repo).unwrap();
+
+        let mut config = config::Config::default();
+        config.pattern_repositories = vec![config::PatternRepositoryConfig {
+            source: "patterns/local-rules".to_string(),
+            ..Default::default()
+        }];
+
+        let resolved = resolve_pattern_repositories_with(&config, repo_root, |_| None);
+
+        assert_eq!(resolved.len(), 1);
+        assert_eq!(
+            resolved.get("patterns/local-rules"),
+            Some(&local_repo.canonicalize().unwrap())
+        );
+    }
+
+    #[test]
+    fn test_resolve_pattern_repositories_accepts_git_sources_via_checkout_helper() {
+        let tempdir = tempfile::tempdir().unwrap();
+        let repo_root = tempdir.path();
+        let checkout_path = repo_root.join("cloned-rules");
+        std::fs::create_dir_all(&checkout_path).unwrap();
+
+        let mut config = config::Config::default();
+        let source = "https://github.com/example/rules.git".to_string();
+        config.pattern_repositories = vec![config::PatternRepositoryConfig {
+            source: source.clone(),
+            ..Default::default()
+        }];
+
+        let checkout_calls = RefCell::new(Vec::new());
+        let resolved = resolve_pattern_repositories_with(&config, repo_root, |candidate| {
+            checkout_calls.borrow_mut().push(candidate.to_string());
+            Some(checkout_path.clone())
+        });
+
+        assert_eq!(checkout_calls.into_inner(), vec![source.clone()]);
+        assert_eq!(resolved.get(&source), Some(&checkout_path));
+    }
+
+    #[test]
+    fn test_resolve_pattern_repositories_skips_broken_sources() {
+        let tempdir = tempfile::tempdir().unwrap();
+        let repo_root = tempdir.path();
+
+        let mut config = config::Config::default();
+        config.pattern_repositories = vec![
+            config::PatternRepositoryConfig {
+                source: "missing/local-rules".to_string(),
+                ..Default::default()
+            },
+            config::PatternRepositoryConfig {
+                source: "https://github.com/example/broken.git".to_string(),
+                ..Default::default()
+            },
+        ];
+
+        let checkout_calls = RefCell::new(Vec::new());
+        let resolved = resolve_pattern_repositories_with(&config, repo_root, |candidate| {
+            checkout_calls.borrow_mut().push(candidate.to_string());
+            None
+        });
+
+        assert!(resolved.is_empty());
+        assert_eq!(
+            checkout_calls.into_inner(),
+            vec!["https://github.com/example/broken.git".to_string()]
+        );
+    }
 }

src/review/context_helpers/pattern_repositories/run.rs

@@ -1,4 +1,4 @@
-use std::path::Path;
+use std::path::{Path, PathBuf};
 
 use tracing::warn;
 
@@ -13,6 +13,17 @@ pub fn resolve_pattern_repositories(
     config: &config::Config,
     repo_root: &Path,
 ) -> PatternRepositoryMap {
+    resolve_pattern_repositories_with(config, repo_root, prepare_pattern_repository_checkout)
+}
+
+pub(super) fn resolve_pattern_repositories_with<F>(
+    config: &config::Config,
+    repo_root: &Path,
+    mut prepare_checkout: F,
+) -> PatternRepositoryMap
+where
+    F: FnMut(&str) -> Option<PathBuf>,
+{
     let mut resolved = PatternRepositoryMap::new();
     if config.pattern_repositories.is_empty() {
         return resolved;
@@ -29,7 +40,7 @@ pub fn resolve_pattern_repositories(
         }
 
         if is_git_source(&repo.source) {
-            if let Some(path) = prepare_pattern_repository_checkout(&repo.source) {
+            if let Some(path) = prepare_checkout(&repo.source) {
                 resolved.insert(repo.source.clone(), path);
                 continue;
             }