refactor: split feedback example helpers

Separate example ranking from example selection so the feedback report can tune filtering and ordering without mixing the two concerns.

Made-with: Cursor

Author: haasonsaas

TODO.md

@@ -72,7 +72,7 @@
 - [x] `src/commands/doctor/command/run.rs`: separate endpoint discovery, recommendation flow, and test helpers.
 - [x] `src/commands/eval/runner/matching.rs`: split required-match search, unexpected-match detection, and rule metric assembly.
 - [x] `src/commands/eval/runner/execute/loading.rs`: separate diff resolution from repo-path resolution if it grows again.
-- [ ] `src/commands/feedback_eval/report/examples.rs`: split ranking helpers from example builders.
+- [x] `src/commands/feedback_eval/report/examples.rs`: split ranking helpers from example builders.
 - [ ] `src/commands/doctor/system.rs`: carve environment probes vs output helpers.
 
 ### Commands backlog

src/commands/feedback_eval/report/examples.rs

@@ -1,77 +1,6 @@
-use std::cmp::Ordering;
+#[path = "examples/build.rs"]
+mod build;
+#[path = "examples/ranking.rs"]
+mod ranking;
 
-use crate::review;
-
-use super::super::{FeedbackEvalComment, FeedbackEvalExample};
-
-const MAX_EXAMPLES: usize = 10;
-
-pub(super) fn build_showcase_candidates(
-    comments: &[FeedbackEvalComment],
-    confidence_threshold: f32,
-) -> Vec<FeedbackEvalExample> {
-    let mut examples = comments
-        .iter()
-        .filter(|comment| {
-            comment.accepted
-                && !review::is_vague_comment_text(&comment.content)
-                && comment
-                    .confidence
-                    .map(|confidence| confidence >= confidence_threshold)
-                    .unwrap_or(true)
-        })
-        .map(FeedbackEvalExample::from)
-        .collect::<Vec<_>>();
-    examples.sort_by(compare_feedback_examples);
-    examples.truncate(MAX_EXAMPLES);
-    examples
-}
-
-pub(super) fn build_vague_rejections(comments: &[FeedbackEvalComment]) -> Vec<FeedbackEvalExample> {
-    let mut examples = comments
-        .iter()
-        .filter(|comment| !comment.accepted && review::is_vague_comment_text(&comment.content))
-        .map(FeedbackEvalExample::from)
-        .collect::<Vec<_>>();
-    examples.sort_by(compare_feedback_examples);
-    examples.truncate(MAX_EXAMPLES);
-    examples
-}
-
-fn compare_feedback_examples(left: &FeedbackEvalExample, right: &FeedbackEvalExample) -> Ordering {
-    right
-        .confidence
-        .partial_cmp(&left.confidence)
-        .unwrap_or(Ordering::Equal)
-        .then_with(|| {
-            severity_rank(right.severity.as_deref()).cmp(&severity_rank(left.severity.as_deref()))
-        })
-        .then_with(|| left.content.cmp(&right.content))
-}
-
-fn severity_rank(severity: Option<&str>) -> usize {
-    match severity.map(|value| value.to_ascii_lowercase()) {
-        Some(value) if value == "error" => 3,
-        Some(value) if value == "warning" => 2,
-        Some(value) if value == "info" => 1,
-        _ => 0,
-    }
-}
-
-impl From<&FeedbackEvalComment> for FeedbackEvalExample {
-    fn from(comment: &FeedbackEvalComment) -> Self {
-        Self {
-            source_kind: comment.source_kind.clone(),
-            review_id: comment.review_id.clone(),
-            repo: comment.repo.clone(),
-            pr_number: comment.pr_number,
-            title: comment.title.clone(),
-            file_path: comment.file_path.clone(),
-            line_number: comment.line_number,
-            category: comment.category.clone(),
-            severity: comment.severity.clone(),
-            confidence: comment.confidence,
-            content: comment.content.clone(),
-        }
-    }
-}
+pub(super) use build::{build_showcase_candidates, build_vague_rejections};

src/commands/feedback_eval/report/examples/build.rs

@@ -0,0 +1,54 @@
+use crate::review;
+
+use super::super::super::{FeedbackEvalComment, FeedbackEvalExample};
+use super::ranking::rank_feedback_examples;
+
+pub(in super::super) fn build_showcase_candidates(
+    comments: &[FeedbackEvalComment],
+    confidence_threshold: f32,
+) -> Vec<FeedbackEvalExample> {
+    let mut examples = comments
+        .iter()
+        .filter(|comment| {
+            comment.accepted
+                && !review::is_vague_comment_text(&comment.content)
+                && comment
+                    .confidence
+                    .map(|confidence| confidence >= confidence_threshold)
+                    .unwrap_or(true)
+        })
+        .map(FeedbackEvalExample::from)
+        .collect::<Vec<_>>();
+    rank_feedback_examples(&mut examples);
+    examples
+}
+
+pub(in super::super) fn build_vague_rejections(
+    comments: &[FeedbackEvalComment],
+) -> Vec<FeedbackEvalExample> {
+    let mut examples = comments
+        .iter()
+        .filter(|comment| !comment.accepted && review::is_vague_comment_text(&comment.content))
+        .map(FeedbackEvalExample::from)
+        .collect::<Vec<_>>();
+    rank_feedback_examples(&mut examples);
+    examples
+}
+
+impl From<&FeedbackEvalComment> for FeedbackEvalExample {
+    fn from(comment: &FeedbackEvalComment) -> Self {
+        Self {
+            source_kind: comment.source_kind.clone(),
+            review_id: comment.review_id.clone(),
+            repo: comment.repo.clone(),
+            pr_number: comment.pr_number,
+            title: comment.title.clone(),
+            file_path: comment.file_path.clone(),
+            line_number: comment.line_number,
+            category: comment.category.clone(),
+            severity: comment.severity.clone(),
+            confidence: comment.confidence,
+            content: comment.content.clone(),
+        }
+    }
+}

src/commands/feedback_eval/report/examples/ranking.rs

@@ -0,0 +1,30 @@
+use std::cmp::Ordering;
+
+use super::super::super::FeedbackEvalExample;
+
+const MAX_EXAMPLES: usize = 10;
+
+pub(super) fn rank_feedback_examples(examples: &mut Vec<FeedbackEvalExample>) {
+    examples.sort_by(compare_feedback_examples);
+    examples.truncate(MAX_EXAMPLES);
+}
+
+fn compare_feedback_examples(left: &FeedbackEvalExample, right: &FeedbackEvalExample) -> Ordering {
+    right
+        .confidence
+        .partial_cmp(&left.confidence)
+        .unwrap_or(Ordering::Equal)
+        .then_with(|| {
+            severity_rank(right.severity.as_deref()).cmp(&severity_rank(left.severity.as_deref()))
+        })
+        .then_with(|| left.content.cmp(&right.content))
+}
+
+fn severity_rank(severity: Option<&str>) -> usize {
+    match severity.map(|value| value.to_ascii_lowercase()) {
+        Some(value) if value == "error" => 3,
+        Some(value) if value == "warning" => 2,
+        Some(value) if value == "info" => 1,
+        _ => 0,
+    }
+}