refactor: split eval command helpers

Separate fixture execution, threshold option preparation, and report emission so the eval command flow stays small and easier to extend.

Made-with: Cursor

Author: haasonsaas

TODO.md

@@ -90,7 +90,7 @@
 - [ ] `src/commands/misc/discussion/command.rs`: separate the interactive loop from single-shot execution.
 - [ ] `src/commands/misc/discussion/selection.rs`: split file loading/ID repair from selection rules.
 - [ ] `src/commands/misc/changelog.rs`: evaluate splitting changelog collection from output formatting.
-- [ ] `src/commands/eval/command.rs`: separate CLI option prep, fixture execution, and report lifecycle.
+- [x] `src/commands/eval/command.rs`: separate CLI option prep, fixture execution, and report lifecycle.
 - [x] `src/commands/feedback_eval/command.rs`: separate input loading from report/output orchestration.
 
 ### Review pipeline backlog

src/commands/eval/command.rs

@@ -1,60 +1,27 @@
+#[path = "command/fixtures.rs"]
+mod fixtures;
+#[path = "command/options.rs"]
+mod options;
+#[path = "command/report.rs"]
+mod report;
+
 use anyhow::Result;
 use std::path::PathBuf;
 
 use crate::config;
 
-use super::fixtures::{collect_eval_fixtures, load_eval_report};
-use super::report::{
-    build_eval_report, evaluation_failure_message, print_eval_report, write_eval_report,
-};
-use super::runner::run_eval_fixture;
-use super::thresholds::{parse_rule_threshold_args, EvalThresholdOptions};
 use super::EvalRunOptions;
+use fixtures::run_eval_fixtures;
+use options::prepare_eval_options;
+use report::emit_eval_report;
 
 pub async fn eval_command(
     config: config::Config,
     fixtures_dir: PathBuf,
     output_path: Option<PathBuf>,
     options: EvalRunOptions,
 ) -> Result<()> {
-    let fixtures = collect_eval_fixtures(&fixtures_dir)?;
-    if fixtures.is_empty() {
-        anyhow::bail!(
-            "No fixture files found in {} (expected .json/.yml/.yaml)",
-            fixtures_dir.display()
-        );
-    }
-
-    let mut results = Vec::new();
-    for fixture in fixtures {
-        results.push(run_eval_fixture(&config, fixture).await?);
-    }
-
-    let baseline = match options.baseline_report.as_deref() {
-        Some(path) => Some(load_eval_report(path)?),
-        None => None,
-    };
-    let min_rule_thresholds = parse_rule_threshold_args(&options.min_rule_f1, "min-rule-f1")?;
-    let max_rule_drop_thresholds =
-        parse_rule_threshold_args(&options.max_rule_f1_drop, "max-rule-f1-drop")?;
-    let threshold_options = EvalThresholdOptions {
-        max_micro_f1_drop: options.max_micro_f1_drop,
-        min_micro_f1: options.min_micro_f1,
-        min_macro_f1: options.min_macro_f1,
-        min_rule_f1: min_rule_thresholds,
-        max_rule_f1_drop: max_rule_drop_thresholds,
-    };
-
-    let report = build_eval_report(results, baseline.as_ref(), &threshold_options);
-    print_eval_report(&report);
-
-    if let Some(path) = output_path.as_deref() {
-        write_eval_report(&report, path).await?;
-    }
-
-    if let Some(message) = evaluation_failure_message(&report) {
-        anyhow::bail!("{}", message);
-    }
-
-    Ok(())
+    let results = run_eval_fixtures(&config, &fixtures_dir).await?;
+    let prepared_options = prepare_eval_options(&options)?;
+    emit_eval_report(results, output_path.as_deref(), prepared_options).await
 }

src/commands/eval/command/fixtures.rs

@@ -0,0 +1,28 @@
+use anyhow::Result;
+use std::path::Path;
+
+use crate::config;
+
+use super::super::fixtures::collect_eval_fixtures;
+use super::super::runner::run_eval_fixture;
+use super::super::EvalFixtureResult;
+
+pub(super) async fn run_eval_fixtures(
+    config: &config::Config,
+    fixtures_dir: &Path,
+) -> Result<Vec<EvalFixtureResult>> {
+    let fixtures = collect_eval_fixtures(fixtures_dir)?;
+    if fixtures.is_empty() {
+        anyhow::bail!(
+            "No fixture files found in {} (expected .json/.yml/.yaml)",
+            fixtures_dir.display()
+        );
+    }
+
+    let mut results = Vec::new();
+    for fixture in fixtures {
+        results.push(run_eval_fixture(config, fixture).await?);
+    }
+
+    Ok(results)
+}

src/commands/eval/command/options.rs

@@ -0,0 +1,31 @@
+use anyhow::Result;
+
+use super::super::fixtures::load_eval_report;
+use super::super::thresholds::{parse_rule_threshold_args, EvalThresholdOptions};
+use super::super::{EvalReport, EvalRunOptions};
+
+pub(super) struct PreparedEvalOptions {
+    pub(super) baseline: Option<EvalReport>,
+    pub(super) threshold_options: EvalThresholdOptions,
+}
+
+pub(super) fn prepare_eval_options(options: &EvalRunOptions) -> Result<PreparedEvalOptions> {
+    let baseline = match options.baseline_report.as_deref() {
+        Some(path) => Some(load_eval_report(path)?),
+        None => None,
+    };
+    let min_rule_thresholds = parse_rule_threshold_args(&options.min_rule_f1, "min-rule-f1")?;
+    let max_rule_drop_thresholds =
+        parse_rule_threshold_args(&options.max_rule_f1_drop, "max-rule-f1-drop")?;
+
+    Ok(PreparedEvalOptions {
+        baseline,
+        threshold_options: EvalThresholdOptions {
+            max_micro_f1_drop: options.max_micro_f1_drop,
+            min_micro_f1: options.min_micro_f1,
+            min_macro_f1: options.min_macro_f1,
+            min_rule_f1: min_rule_thresholds,
+            max_rule_f1_drop: max_rule_drop_thresholds,
+        },
+    })
+}

src/commands/eval/command/report.rs

@@ -0,0 +1,31 @@
+use anyhow::Result;
+use std::path::Path;
+
+use super::super::report::{
+    build_eval_report, evaluation_failure_message, print_eval_report, write_eval_report,
+};
+use super::super::EvalFixtureResult;
+use super::options::PreparedEvalOptions;
+
+pub(super) async fn emit_eval_report(
+    results: Vec<EvalFixtureResult>,
+    output_path: Option<&Path>,
+    prepared_options: PreparedEvalOptions,
+) -> Result<()> {
+    let report = build_eval_report(
+        results,
+        prepared_options.baseline.as_ref(),
+        &prepared_options.threshold_options,
+    );
+    print_eval_report(&report);
+
+    if let Some(path) = output_path {
+        write_eval_report(&report, path).await?;
+    }
+
+    if let Some(message) = evaluation_failure_message(&report) {
+        anyhow::bail!("{}", message);
+    }
+
+    Ok(())
+}