feat: add comment resolution timestamps

haasonsaas · haasonsaas · commit a1d16990cbb3 · 2026-03-14T00:12:59.000-07:00
diff --git a/TODO.md b/TODO.md
@@ -43,7 +43,7 @@ This roadmap is derived from deep research into Greptile's public docs, blog, MC
 16. [x] Distinguish informational findings from blocking findings in lifecycle and readiness calculations.
 17. [x] Add "critical blockers" summary cards for unresolved `Error` and `Warning` comments.
 18. [x] Add per-PR readiness timelines showing when a review became mergeable.
-19. [ ] Store resolution timestamps for findings so mean-time-to-fix can be measured.
+19. [x] Store resolution timestamps for findings so mean-time-to-fix can be measured.
 20. [x] Add CLI and API surfaces to query PR readiness without opening the web UI.
 
 ## 3. Agentic Validation Loops
diff --git a/migrations/004_comment_resolved_at.sql b/migrations/004_comment_resolved_at.sql
@@ -0,0 +1,2 @@
+ALTER TABLE comments
+ADD COLUMN IF NOT EXISTS resolved_at TIMESTAMPTZ;
diff --git a/src/commands/eval/pattern/matching/run.rs b/src/commands/eval/pattern/matching/run.rs
@@ -53,6 +53,7 @@ mod tests {
             fix_effort: FixEffort::Low,
             feedback: None,
             status: crate::core::comment::CommentStatus::Open,
+            resolved_at: None,
         };
 
         let pattern = EvalPattern {
@@ -85,6 +86,7 @@ mod tests {
             fix_effort: FixEffort::Medium,
             feedback: None,
             status: crate::core::comment::CommentStatus::Open,
+            resolved_at: None,
         };
 
         let pattern = EvalPattern {
@@ -116,6 +118,7 @@ mod tests {
             fix_effort: FixEffort::Low,
             feedback: None,
             status: crate::core::comment::CommentStatus::Open,
+            resolved_at: None,
         };
 
         let pattern = EvalPattern {
@@ -145,6 +148,7 @@ mod tests {
             fix_effort: FixEffort::Low,
             feedback: None,
             status: crate::core::comment::CommentStatus::Open,
+            resolved_at: None,
         };
 
         let pattern = EvalPattern {
@@ -178,6 +182,7 @@ mod tests {
             fix_effort: FixEffort::Low,
             feedback: None,
             status: crate::core::comment::CommentStatus::Open,
+            resolved_at: None,
         };
 
         let pattern = EvalPattern {
@@ -207,6 +212,7 @@ mod tests {
             fix_effort: FixEffort::Low,
             feedback: None,
             status: crate::core::comment::CommentStatus::Open,
+            resolved_at: None,
         };
 
         let pattern = EvalPattern {
@@ -238,6 +244,7 @@ mod tests {
             fix_effort: FixEffort::Low,
             feedback: None,
             status: crate::core::comment::CommentStatus::Open,
+            resolved_at: None,
         };
 
         let pattern = EvalPattern {
@@ -268,6 +275,7 @@ mod tests {
             fix_effort: FixEffort::Low,
             feedback: None,
             status: crate::core::comment::CommentStatus::Open,
+            resolved_at: None,
         };
 
         let pattern = EvalPattern {
@@ -302,6 +310,7 @@ mod tests {
             fix_effort: FixEffort::Low,
             feedback: None,
             status: crate::core::comment::CommentStatus::Open,
+            resolved_at: None,
         };
 
         let pattern = EvalPattern {
@@ -335,6 +344,7 @@ mod tests {
             fix_effort: FixEffort::Medium,
             feedback: None,
             status: crate::core::comment::CommentStatus::Open,
+            resolved_at: None,
         };
 
         let pattern = EvalPattern {
@@ -371,6 +381,7 @@ mod tests {
             fix_effort: FixEffort::Medium,
             feedback: None,
             status: crate::core::comment::CommentStatus::Open,
+            resolved_at: None,
         };
 
         let pattern = EvalPattern {
@@ -408,6 +419,7 @@ mod tests {
             fix_effort: FixEffort::Low,
             feedback: None,
             status: crate::core::comment::CommentStatus::Open,
+            resolved_at: None,
         };
 
         let pattern = EvalPattern {
diff --git a/src/commands/feedback_eval/input.rs b/src/commands/feedback_eval/input.rs
@@ -39,6 +39,7 @@ mod tests {
             fix_effort: FixEffort::Low,
             feedback: feedback.map(str::to_string),
             status: crate::core::comment::CommentStatus::Open,
+            resolved_at: None,
         }
     }
 
diff --git a/src/commands/misc/discussion/selection/rules.rs b/src/commands/misc/discussion/selection/rules.rs
@@ -65,6 +65,7 @@ mod tests {
             fix_effort: core::comment::FixEffort::Low,
             feedback: None,
             status: crate::core::comment::CommentStatus::Open,
+            resolved_at: None,
         };
         let result = select_discussion_comment(std::slice::from_ref(&comment), None, None).unwrap();
         assert_eq!(result.id, "cmt_1");
diff --git a/src/commands/misc/feedback/apply/accept.rs b/src/commands/misc/feedback/apply/accept.rs
@@ -37,6 +37,7 @@ mod tests {
             fix_effort: core::comment::FixEffort::Low,
             feedback: None,
             status: crate::core::comment::CommentStatus::Open,
+            resolved_at: None,
         };
 
         let comments = vec![comment];
diff --git a/src/core/comment.rs b/src/core/comment.rs
@@ -120,6 +120,7 @@ impl CommentSynthesizer {
             fix_effort,
             feedback: None,
             status: CommentStatus::Open,
+            resolved_at: None,
         })
     }
 }
diff --git a/src/core/comment/summary.rs b/src/core/comment/summary.rs
@@ -235,6 +235,7 @@ mod tests {
             fix_effort: FixEffort::Low,
             feedback: None,
             status,
+            resolved_at: None,
         }
     }
 
diff --git a/src/core/comment/types.rs b/src/core/comment/types.rs
@@ -22,6 +22,8 @@ pub struct Comment {
     pub feedback: Option<String>,
     #[serde(default)]
     pub status: CommentStatus,
+    #[serde(default, skip_serializing_if = "Option::is_none")]
+    pub resolved_at: Option<i64>,
 }
 
 #[derive(Debug, Clone, Serialize, Deserialize)]
diff --git a/src/core/composable_pipeline.rs b/src/core/composable_pipeline.rs
@@ -374,6 +374,7 @@ mod tests {
             fix_effort: FixEffort::Medium,
             feedback: None,
             status: crate::core::comment::CommentStatus::Open,
+            resolved_at: None,
         }
     }
 
diff --git a/src/core/multi_pass.rs b/src/core/multi_pass.rs
@@ -366,6 +366,7 @@ mod tests {
             fix_effort: FixEffort::Medium,
             feedback: None,
             status: crate::core::comment::CommentStatus::Open,
+            resolved_at: None,
         }
     }
 
diff --git a/src/output/format.rs b/src/output/format.rs
@@ -690,6 +690,7 @@ mod tests {
             fix_effort: core::comment::FixEffort::Low,
             feedback: None,
             status: crate::core::comment::CommentStatus::Open,
+            resolved_at: None,
         }
     }
 
diff --git a/src/plugins/builtin/duplicate_filter.rs b/src/plugins/builtin/duplicate_filter.rs
@@ -56,6 +56,7 @@ mod tests {
             fix_effort: FixEffort::Low,
             feedback: None,
             status: crate::core::comment::CommentStatus::Open,
+            resolved_at: None,
         }
     }
 
diff --git a/src/review/feedback/record.rs b/src/review/feedback/record.rs
@@ -67,6 +67,7 @@ mod tests {
             fix_effort: core::comment::FixEffort::Medium,
             feedback: None,
             status: crate::core::comment::CommentStatus::Open,
+            resolved_at: None,
         }
     }
 
diff --git a/src/review/filters.rs b/src/review/filters.rs
@@ -50,6 +50,7 @@ mod tests {
             fix_effort: core::comment::FixEffort::Low,
             feedback: None,
             status: crate::core::comment::CommentStatus::Open,
+            resolved_at: None,
         }
     }
 
diff --git a/src/review/pipeline/postprocess/dedup.rs b/src/review/pipeline/postprocess/dedup.rs
@@ -54,6 +54,7 @@ mod tests {
             fix_effort: core::comment::FixEffort::Medium,
             feedback: None,
             status: crate::core::comment::CommentStatus::Open,
+            resolved_at: None,
         }
     }
 
diff --git a/src/review/rule_helpers/reporting.rs b/src/review/rule_helpers/reporting.rs
@@ -38,6 +38,7 @@ mod tests {
             fix_effort: core::comment::FixEffort::Low,
             feedback: None,
             status: crate::core::comment::CommentStatus::Open,
+            resolved_at: None,
         }
     }
 
diff --git a/src/review/rule_helpers/runtime.rs b/src/review/rule_helpers/runtime.rs
@@ -35,6 +35,7 @@ mod tests {
             fix_effort: core::comment::FixEffort::Low,
             feedback: None,
             status: crate::core::comment::CommentStatus::Open,
+            resolved_at: None,
         }
     }
 
diff --git a/src/review/verification/tests.rs b/src/review/verification/tests.rs
@@ -62,6 +62,7 @@ fn make_comment(id: &str, content: &str, line: usize) -> Comment {
         fix_effort: FixEffort::Low,
         feedback: None,
         status: crate::core::comment::CommentStatus::Open,
+        resolved_at: None,
     }
 }
 
diff --git a/src/server/api.rs b/src/server/api.rs
@@ -1251,6 +1251,23 @@ pub async fn submit_feedback(
     Ok(Json(FeedbackResponse { ok: true }))
 }
 
+fn apply_comment_lifecycle_transition(
+    comment: &mut crate::core::comment::Comment,
+    next_status: CommentStatus,
+    timestamp: i64,
+) -> bool {
+    if comment.status == next_status {
+        return false;
+    }
+
+    comment.status = next_status;
+    comment.resolved_at = match next_status {
+        CommentStatus::Resolved => Some(timestamp),
+        _ => None,
+    };
+    true
+}
+
 pub async fn update_comment_lifecycle(
     State(state): State<Arc<AppState>>,
     Path(id): Path<String>,
@@ -1268,12 +1285,7 @@ pub async fn update_comment_lifecycle(
             .find(|c| c.id == request.comment_id)
             .ok_or(StatusCode::NOT_FOUND)?;
 
-        if comment.status == next_status {
-            false
-        } else {
-            comment.status = next_status;
-            true
-        }
+        apply_comment_lifecycle_transition(comment, next_status, current_timestamp())
     };
 
     if status_changed {
@@ -3827,6 +3839,40 @@ mod tests {
         assert!(req.post_results);
     }
 
+    #[test]
+    fn test_apply_comment_lifecycle_transition_sets_and_clears_resolved_at() {
+        let mut comment = make_search_comment("lifecycle", CommentStatus::Open);
+
+        assert!(apply_comment_lifecycle_transition(
+            &mut comment,
+            CommentStatus::Resolved,
+            123,
+        ));
+        assert_eq!(comment.status, CommentStatus::Resolved);
+        assert_eq!(comment.resolved_at, Some(123));
+
+        assert!(apply_comment_lifecycle_transition(
+            &mut comment,
+            CommentStatus::Open,
+            456,
+        ));
+        assert_eq!(comment.status, CommentStatus::Open);
+        assert_eq!(comment.resolved_at, None);
+    }
+
+    #[test]
+    fn test_apply_comment_lifecycle_transition_is_noop_when_status_matches() {
+        let mut comment = make_search_comment("lifecycle", CommentStatus::Resolved);
+        comment.resolved_at = Some(123);
+
+        assert!(!apply_comment_lifecycle_transition(
+            &mut comment,
+            CommentStatus::Resolved,
+            456,
+        ));
+        assert_eq!(comment.resolved_at, Some(123));
+    }
+
     fn make_search_comment(id: &str, status: CommentStatus) -> crate::core::Comment {
         crate::core::Comment {
             id: id.to_string(),
@@ -3843,6 +3889,7 @@ mod tests {
             fix_effort: crate::core::comment::FixEffort::Low,
             feedback: None,
             status,
+            resolved_at: None,
         }
     }
 
diff --git a/src/server/pr_readiness.rs b/src/server/pr_readiness.rs
@@ -275,6 +275,7 @@ mod tests {
             fix_effort: FixEffort::Low,
             feedback: None,
             status,
+            resolved_at: None,
         }
     }
 
diff --git a/src/server/state.rs b/src/server/state.rs
@@ -848,6 +848,7 @@ mod tests {
             fix_effort: FixEffort::Low,
             feedback: None,
             status: crate::core::comment::CommentStatus::Open,
+            resolved_at: None,
         }];
         let summary = crate::core::CommentSynthesizer::generate_summary(&comments);
 
@@ -938,6 +939,7 @@ mod tests {
                 fix_effort: FixEffort::Low,
                 feedback: None,
                 status: crate::core::comment::CommentStatus::Open,
+                resolved_at: None,
             },
             Comment {
                 id: "c2".to_string(),
@@ -954,6 +956,7 @@ mod tests {
                 fix_effort: FixEffort::Low,
                 feedback: None,
                 status: crate::core::comment::CommentStatus::Open,
+                resolved_at: None,
             },
             Comment {
                 id: "c3".to_string(),
@@ -970,6 +973,7 @@ mod tests {
                 fix_effort: FixEffort::Medium,
                 feedback: None,
                 status: crate::core::comment::CommentStatus::Open,
+                resolved_at: None,
             },
         ];
         assert_eq!(count_reviewed_files(&comments), 2);
@@ -1389,6 +1393,7 @@ mod tests {
             fix_effort: FixEffort::Low,
             feedback: None,
             status: crate::core::comment::CommentStatus::Open,
+            resolved_at: None,
         }];
         let summary = crate::core::CommentSynthesizer::generate_summary(&comments);
 
diff --git a/src/server/storage_json.rs b/src/server/storage_json.rs
@@ -475,6 +475,7 @@ mod tests {
             fix_effort: FixEffort::Low,
             feedback: None,
             status: crate::core::comment::CommentStatus::Open,
+            resolved_at: None,
         }
     }
 
@@ -525,6 +526,8 @@ mod tests {
             make_comment("c1", "src/main.rs"),
             make_comment("c2", "src/lib.rs"),
         ];
+        session.comments[1].status = crate::core::comment::CommentStatus::Resolved;
+        session.comments[1].resolved_at = Some(123);
         session.summary = Some(ReviewSummary {
             total_comments: 2,
             by_severity: HashMap::from([("Warning".to_string(), 2)]),
@@ -554,6 +557,7 @@ mod tests {
         backend.save_review(&session).await.unwrap();
         let loaded = backend.get_review("r-full").await.unwrap().unwrap();
         assert_eq!(loaded.comments.len(), 2);
+        assert_eq!(loaded.comments[1].resolved_at, Some(123));
         assert!(loaded.summary.is_some());
         assert_eq!(loaded.summary.unwrap().overall_score, 8.0);
     }
diff --git a/src/server/storage_pg.rs b/src/server/storage_pg.rs
diff --git a/web/src/api/types.ts b/web/src/api/types.ts

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+ALTER TABLE comments`
	`2`	`+ADD COLUMN IF NOT EXISTS resolved_at TIMESTAMPTZ;`
Original file line number	Diff line number	Diff line change
`@@ -39,6 +39,7 @@ mod tests {`
`39`	`39`	`fix_effort: FixEffort::Low,`
`40`	`40`	`feedback: feedback.map(str::to_string),`
`41`	`41`	`status: crate::core::comment::CommentStatus::Open,`
	`42`	`+ resolved_at: None,`
`42`	`43`	`}`
`43`	`44`	`}`
`44`	`45`
Original file line number	Diff line number	Diff line change
`@@ -120,6 +120,7 @@ impl CommentSynthesizer {`
`120`	`120`	`fix_effort,`
`121`	`121`	`feedback: None,`
`122`	`122`	`status: CommentStatus::Open,`
	`123`	`+ resolved_at: None,`
`123`	`124`	`})`
`124`	`125`	`}`
`125`	`126`	`}`
Original file line number	Diff line number	Diff line change
`@@ -235,6 +235,7 @@ mod tests {`
`235`	`235`	`fix_effort: FixEffort::Low,`
`236`	`236`	`feedback: None,`
`237`	`237`	`status,`
	`238`	`+ resolved_at: None,`
`238`	`239`	`}`
`239`	`240`	`}`
`240`	`241`
Original file line number	Diff line number	Diff line change
`@@ -22,6 +22,8 @@ pub struct Comment {`
`22`	`22`	`pub feedback: Option<String>,`
`23`	`23`	`#[serde(default)]`
`24`	`24`	`pub status: CommentStatus,`
	`25`	`+ #[serde(default, skip_serializing_if = "Option::is_none")]`
	`26`	`+ pub resolved_at: Option<i64>,`
`25`	`27`	`}`
`26`	`28`
`27`	`29`	`#[derive(Debug, Clone, Serialize, Deserialize)]`
Original file line number	Diff line number	Diff line change
`@@ -374,6 +374,7 @@ mod tests {`
`374`	`374`	`fix_effort: FixEffort::Medium,`
`375`	`375`	`feedback: None,`
`376`	`376`	`status: crate::core::comment::CommentStatus::Open,`
	`377`	`+ resolved_at: None,`
`377`	`378`	`}`
`378`	`379`	`}`
`379`	`380`