refactor: split review postprocess dedup helpers

Made-with: Cursor

Author: haasonsaas

TODO.md

@@ -105,7 +105,7 @@
 - [x] `src/review/pipeline/services.rs`: separate service wiring from optional feature initialization.
 - [x] `src/review/pipeline/file_context/sources.rs`: split repo sources, symbol sources, and supplemental context sources.
 - [x] `src/review/pipeline/comments.rs`: separate comment assembly, filtering, and metadata stamping.
-- [ ] `src/review/pipeline/postprocess/dedup.rs`: split duplicate detection, scoring, and merge/rewrite behavior.
+- [x] `src/review/pipeline/postprocess/dedup.rs`: split duplicate detection, scoring, and merge/rewrite behavior.
 - [ ] `src/review/pipeline/postprocess/feedback.rs`: separate store lookups from suppression/annotation decisions.
 - [ ] `src/review/pipeline/execution/dispatcher.rs`: carve request scheduling, concurrency control, and result collection.
 - [ ] `src/review/pipeline.rs`: keep trimming top-level orchestration as helpers mature.

src/review/pipeline/postprocess/dedup.rs

@@ -1,5 +1,13 @@
+#[path = "dedup/matching.rs"]
+mod matching;
+#[path = "dedup/merge.rs"]
+mod merge;
+
 use crate::core;
 
+use matching::find_dominated_comment_index;
+use merge::merge_specialized_comment;
+
 pub(super) fn deduplicate_specialized_comments(
     mut comments: Vec<core::Comment>,
 ) -> Vec<core::Comment> {
@@ -15,22 +23,8 @@ pub(super) fn deduplicate_specialized_comments(
 
     let mut deduped: Vec<core::Comment> = Vec::with_capacity(comments.len());
     for comment in comments {
-        let dominated = deduped.iter_mut().find(|existing| {
-            existing.file_path == comment.file_path
-                && existing.line_number == comment.line_number
-                && core::multi_pass::content_similarity(&existing.content, &comment.content) > 0.6
-        });
-        if let Some(existing) = dominated {
-            if comment.confidence > existing.confidence {
-                existing.content = comment.content;
-                existing.confidence = comment.confidence;
-                existing.severity = comment.severity;
-            }
-            for tag in &comment.tags {
-                if !existing.tags.contains(tag) {
-                    existing.tags.push(tag.clone());
-                }
-            }
+        if let Some(index) = find_dominated_comment_index(&deduped, &comment) {
+            merge_specialized_comment(&mut deduped[index], comment);
         } else {
             deduped.push(comment);
         }

src/review/pipeline/postprocess/dedup/matching.rs

@@ -0,0 +1,12 @@
+use crate::core;
+
+pub(super) fn find_dominated_comment_index(
+    deduped: &[core::Comment],
+    comment: &core::Comment,
+) -> Option<usize> {
+    deduped.iter().position(|existing| {
+        existing.file_path == comment.file_path
+            && existing.line_number == comment.line_number
+            && core::multi_pass::content_similarity(&existing.content, &comment.content) > 0.6
+    })
+}

src/review/pipeline/postprocess/dedup/merge.rs

@@ -0,0 +1,15 @@
+use crate::core;
+
+pub(super) fn merge_specialized_comment(existing: &mut core::Comment, comment: core::Comment) {
+    if comment.confidence > existing.confidence {
+        existing.content = comment.content;
+        existing.confidence = comment.confidence;
+        existing.severity = comment.severity;
+    }
+
+    for tag in &comment.tags {
+        if !existing.tags.contains(tag) {
+            existing.tags.push(tag.clone());
+        }
+    }
+}