Skip to content

Use %I64d for bigint args in collector RAISERROR debug output (#987) #988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erikdarlingdata merged 1 commit into from
May 22, 2026
Merged

Use %I64d for bigint args in collector RAISERROR debug output (#987) #988

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion install/05_delta_framework.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1189,7 +1189,7 @@ BEGIN

IF @debug = 1
BEGIN
RAISERROR(N'Updated %d rows with delta calculations for %s', 0, 1, @rows_updated, @table_name) WITH NOWAIT;
RAISERROR(N'Updated %I64d rows with delta calculations for %s', 0, 1, @rows_updated, @table_name) WITH NOWAIT;
END;

/*
Expand Down
2 changes: 1 addition & 1 deletion install/07_collect_wait_stats.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ BEGIN

IF @debug = 1
BEGIN
RAISERROR(N'Collected %d wait stats rows', 0, 1, @rows_collected) WITH NOWAIT;
RAISERROR(N'Collected %I64d wait stats rows', 0, 1, @rows_collected) WITH NOWAIT;
END;

COMMIT TRANSACTION;
Expand Down
2 changes: 1 addition & 1 deletion install/08_collect_query_stats.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -674,7 +674,7 @@ BEGIN

IF @debug = 1
BEGIN
RAISERROR(N'Collected %d query stats rows', 0, 1, @rows_collected) WITH NOWAIT;
RAISERROR(N'Collected %I64d query stats rows', 0, 1, @rows_collected) WITH NOWAIT;
END;

COMMIT TRANSACTION;
Expand Down
2 changes: 1 addition & 1 deletion install/09_collect_query_store.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -974,7 +974,7 @@ BEGIN

IF @debug = 1
BEGIN
RAISERROR(N'Collected %d Query Store rows', 0, 1, @rows_collected) WITH NOWAIT;
RAISERROR(N'Collected %I64d Query Store rows', 0, 1, @rows_collected) WITH NOWAIT;
END;
END TRY
BEGIN CATCH
Expand Down
2 changes: 1 addition & 1 deletion install/10_collect_procedure_stats.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -822,7 +822,7 @@ BEGIN

IF @debug = 1
BEGIN
RAISERROR(N'Collected %d procedure/trigger/function stats rows', 0, 1, @rows_collected) WITH NOWAIT;
RAISERROR(N'Collected %I64d procedure/trigger/function stats rows', 0, 1, @rows_collected) WITH NOWAIT;
END;

COMMIT TRANSACTION;
Expand Down
2 changes: 1 addition & 1 deletion install/11_collect_query_snapshots.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,7 @@ BEGIN

IF @debug = 1
BEGIN
RAISERROR(N'Collected %d query snapshots', 0, 1, @rows_collected) WITH NOWAIT;
RAISERROR(N'Collected %I64d query snapshots', 0, 1, @rows_collected) WITH NOWAIT;
END;

END TRY
Expand Down
2 changes: 1 addition & 1 deletion install/14_collect_memory_stats.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ BEGIN

IF @debug = 1
BEGIN
RAISERROR(N'Collected %d memory stats rows', 0, 1, @rows_collected) WITH NOWAIT;
RAISERROR(N'Collected %I64d memory stats rows', 0, 1, @rows_collected) WITH NOWAIT;
END;

COMMIT TRANSACTION;
Expand Down
2 changes: 1 addition & 1 deletion install/15_collect_memory_grant_stats.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ BEGIN

IF @debug = 1
BEGIN
RAISERROR(N'Collected %d memory grant stats rows', 0, 1, @rows_collected) WITH NOWAIT;
RAISERROR(N'Collected %I64d memory grant stats rows', 0, 1, @rows_collected) WITH NOWAIT;
END;

COMMIT TRANSACTION;
Expand Down
2 changes: 1 addition & 1 deletion install/16_collect_memory_clerks_stats.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ BEGIN

IF @debug = 1
BEGIN
RAISERROR(N'Collected %d memory clerk stats rows', 0, 1, @rows_collected) WITH NOWAIT;
RAISERROR(N'Collected %I64d memory clerk stats rows', 0, 1, @rows_collected) WITH NOWAIT;
END;

COMMIT TRANSACTION;
Expand Down
2 changes: 1 addition & 1 deletion install/17_collect_cpu_scheduler_stats.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,7 @@ BEGIN

IF @debug = 1
BEGIN
RAISERROR(N'Collected %d CPU scheduler stats rows', 0, 1, @rows_collected) WITH NOWAIT;
RAISERROR(N'Collected %I64d CPU scheduler stats rows', 0, 1, @rows_collected) WITH NOWAIT;
END;

COMMIT TRANSACTION;
Expand Down
2 changes: 1 addition & 1 deletion install/18_collect_cpu_utilization_stats.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ BEGIN

IF @debug = 1
BEGIN
RAISERROR(N'Collected %d CPU utilization stats rows', 0, 1, @rows_collected) WITH NOWAIT;
RAISERROR(N'Collected %I64d CPU utilization stats rows', 0, 1, @rows_collected) WITH NOWAIT;
END;

COMMIT TRANSACTION;
Expand Down
2 changes: 1 addition & 1 deletion install/19_collect_perfmon_stats.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ BEGIN

IF @debug = 1
BEGIN
RAISERROR(N'Collected %d perfmon stats rows', 0, 1, @rows_collected) WITH NOWAIT;
RAISERROR(N'Collected %I64d perfmon stats rows', 0, 1, @rows_collected) WITH NOWAIT;
END;

COMMIT TRANSACTION;
Expand Down
2 changes: 1 addition & 1 deletion install/20_collect_file_io_stats.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ BEGIN

IF @debug = 1
BEGIN
RAISERROR(N'Collected %d file I/O stats rows', 0, 1, @rows_collected) WITH NOWAIT;
RAISERROR(N'Collected %I64d file I/O stats rows', 0, 1, @rows_collected) WITH NOWAIT;
END;

COMMIT TRANSACTION;
Expand Down
2 changes: 1 addition & 1 deletion install/22_collect_blocked_processes.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,7 @@ BEGIN

IF @debug = 1
BEGIN
RAISERROR(N'Collected %d blocked process events', 0, 1, @rows_collected) WITH NOWAIT;
RAISERROR(N'Collected %I64d blocked process events', 0, 1, @rows_collected) WITH NOWAIT;
END;

COMMIT TRANSACTION;
Expand Down
4 changes: 2 additions & 2 deletions install/26_blocking_deadlock_analyzer.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ BEGIN

IF @debug = 1
BEGIN
RAISERROR(N'Aggregated %d database(s) with blocking events', 0, 1, @rows_collected) WITH NOWAIT;
RAISERROR(N'Aggregated %I64d database(s) with blocking events', 0, 1, @rows_collected) WITH NOWAIT;
END;
END
ELSE
Expand Down Expand Up @@ -425,7 +425,7 @@ BEGIN

IF @debug = 1
BEGIN
RAISERROR(N'Logged %d critical issue(s) for blocking/deadlock events', 0, 1, @rows_collected) WITH NOWAIT;
RAISERROR(N'Logged %I64d critical issue(s) for blocking/deadlock events', 0, 1, @rows_collected) WITH NOWAIT;
END;

/*
Expand Down
2 changes: 1 addition & 1 deletion install/27_collect_ring_buffer_events.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ BEGIN

IF @debug = 1
BEGIN
RAISERROR(N'Collected %d memory pressure events', 0, 1, @rows_collected) WITH NOWAIT;
RAISERROR(N'Collected %I64d memory pressure events', 0, 1, @rows_collected) WITH NOWAIT;
END;

COMMIT TRANSACTION;
Expand Down
2 changes: 1 addition & 1 deletion install/28_collect_system_health_wrapper.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ BEGIN

IF @debug = 1
BEGIN
RAISERROR(N'sp_HealthParser completed - %d total rows collected across all tables', 0, 1, @rows_collected) WITH NOWAIT;
RAISERROR(N'sp_HealthParser completed - %I64d total rows collected across all tables', 0, 1, @rows_collected) WITH NOWAIT;
END;

END TRY
Expand Down
2 changes: 1 addition & 1 deletion install/29_collect_default_trace.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,7 +438,7 @@ BEGIN

IF @debug = 1
BEGIN
RAISERROR(N'Collected %d default trace events', 0, 1, @rows_collected) WITH NOWAIT;
RAISERROR(N'Collected %I64d default trace events', 0, 1, @rows_collected) WITH NOWAIT;
END;

/*
Expand Down
2 changes: 1 addition & 1 deletion install/30_collect_trace_management.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,7 +469,7 @@ BEGIN

IF @debug = 1
BEGIN
RAISERROR(N'Started trace ID: %d with filters - Duration >= %d microseconds OR CPU >= %d ms', 0, 1,
RAISERROR(N'Started trace ID: %d with filters - Duration >= %I64d microseconds OR CPU >= %d ms', 0, 1,
@trace_id, @duration_threshold_ms, @cpu_threshold_ms) WITH NOWAIT;
END;
END;
Expand Down
6 changes: 3 additions & 3 deletions install/31_collect_trace_analysis.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@ BEGIN
IF @debug = 1
BEGIN
DECLARE @events_from_file bigint = ROWCOUNT_BIG();
RAISERROR(N'Retrieved %d events from this trace file', 0, 1, @events_from_file) WITH NOWAIT;
RAISERROR(N'Retrieved %I64d events from this trace file', 0, 1, @events_from_file) WITH NOWAIT;
END;

END TRY
Expand All @@ -319,7 +319,7 @@ BEGIN

IF @debug = 1
BEGIN
RAISERROR(N'Found %d traces, collected %d total events', 0, 1, @trace_count, @rows_collected) WITH NOWAIT;
RAISERROR(N'Found %d traces, collected %I64d total events', 0, 1, @trace_count, @rows_collected) WITH NOWAIT;
END;

IF @trace_count = 0
Expand Down Expand Up @@ -413,7 +413,7 @@ BEGIN

IF @debug = 1
BEGIN
RAISERROR(N'Inserted %d new trace analysis records', 0, 1, @rows_collected) WITH NOWAIT;
RAISERROR(N'Inserted %I64d new trace analysis records', 0, 1, @rows_collected) WITH NOWAIT;
END;
END;
ELSE
Expand Down
2 changes: 1 addition & 1 deletion install/32_collect_latch_stats.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ BEGIN

IF @debug = 1
BEGIN
RAISERROR(N'Collected %d latch stats rows', 0, 1, @rows_collected) WITH NOWAIT;
RAISERROR(N'Collected %I64d latch stats rows', 0, 1, @rows_collected) WITH NOWAIT;
END;

COMMIT TRANSACTION;
Expand Down
2 changes: 1 addition & 1 deletion install/33_collect_spinlock_stats.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ BEGIN

IF @debug = 1
BEGIN
RAISERROR(N'Collected %d spinlock stats rows', 0, 1, @rows_collected) WITH NOWAIT;
RAISERROR(N'Collected %I64d spinlock stats rows', 0, 1, @rows_collected) WITH NOWAIT;
END;

COMMIT TRANSACTION;
Expand Down
2 changes: 1 addition & 1 deletion install/34_collect_tempdb_stats.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ BEGIN

IF @debug = 1
BEGIN
RAISERROR(N'Collected %d tempdb stats rows', 0, 1, @rows_collected) WITH NOWAIT;
RAISERROR(N'Collected %I64d tempdb stats rows', 0, 1, @rows_collected) WITH NOWAIT;
END;

COMMIT TRANSACTION;
Expand Down
2 changes: 1 addition & 1 deletion install/35_collect_plan_cache_stats.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ BEGIN

IF @debug = 1
BEGIN
RAISERROR(N'Collected %d plan cache stats rows', 0, 1, @rows_collected) WITH NOWAIT;
RAISERROR(N'Collected %I64d plan cache stats rows', 0, 1, @rows_collected) WITH NOWAIT;
END;

COMMIT TRANSACTION;
Expand Down
2 changes: 1 addition & 1 deletion install/36_collect_session_stats.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ BEGIN

IF @debug = 1
BEGIN
RAISERROR(N'Collected %d session stats rows', 0, 1, @rows_collected) WITH NOWAIT;
RAISERROR(N'Collected %I64d session stats rows', 0, 1, @rows_collected) WITH NOWAIT;
END;

COMMIT TRANSACTION;
Expand Down
2 changes: 1 addition & 1 deletion install/37_collect_waiting_tasks.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ BEGIN
BEGIN
IF @rows_collected > 0
BEGIN
RAISERROR(N'Collected %d waiting tasks', 0, 1, @rows_collected) WITH NOWAIT;
RAISERROR(N'Collected %I64d waiting tasks', 0, 1, @rows_collected) WITH NOWAIT;

/*
Show top wait types from this collection
Expand Down
2 changes: 1 addition & 1 deletion install/43_data_retention.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,7 +596,7 @@ WHERE ' + QUOTENAME(@time_column_name) + N' < @retention_date_param;';
BEGIN
DECLARE @duration_ms integer = DATEDIFF(MILLISECOND, @start_time, SYSDATETIME());
RAISERROR(N'', 0, 1) WITH NOWAIT;
RAISERROR(N'Data retention completed: %d total rows deleted from %d tables in %d ms', 0, 1,
RAISERROR(N'Data retention completed: %I64d total rows deleted from %d tables in %d ms', 0, 1,
@total_deleted,
@table_count,
@duration_ms
Expand Down
4 changes: 2 additions & 2 deletions install/50_configuration_issues_analyzer.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ BEGIN

IF @debug = 1
BEGIN
RAISERROR(N'Logged %d Query Store disabled issues', 0, 1, @rows_collected) WITH NOWAIT;
RAISERROR(N'Logged %I64d Query Store disabled issues', 0, 1, @rows_collected) WITH NOWAIT;
END;

/*
Expand Down Expand Up @@ -994,7 +994,7 @@ BEGIN

IF @debug = 1
BEGIN
RAISERROR(N'Configuration issues analysis complete: %d total issues logged', 0, 1, @rows_collected) WITH NOWAIT;
RAISERROR(N'Configuration issues analysis complete: %I64d total issues logged', 0, 1, @rows_collected) WITH NOWAIT;
END;

END TRY
Expand Down
2 changes: 1 addition & 1 deletion install/51_collect_running_jobs.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ BEGIN
BEGIN
IF @rows_collected > 0
BEGIN
RAISERROR(N'Collected %d running jobs', 0, 1, @rows_collected) WITH NOWAIT;
RAISERROR(N'Collected %I64d running jobs', 0, 1, @rows_collected) WITH NOWAIT;

SELECT TOP (10)
rj.job_name,
Expand Down
2 changes: 1 addition & 1 deletion install/52_collect_database_size_stats.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,7 @@ BEGIN
*/
IF @debug = 1
BEGIN
RAISERROR(N'Collected %d database size rows', 0, 1, @rows_collected) WITH NOWAIT;
RAISERROR(N'Collected %I64d database size rows', 0, 1, @rows_collected) WITH NOWAIT;

SELECT TOP (20)
dss.database_name,
Expand Down
2 changes: 1 addition & 1 deletion install/53_collect_server_properties.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,7 @@ BEGIN
*/
IF @debug = 1
BEGIN
RAISERROR(N'Collected %d server properties row(s)', 0, 1, @rows_collected) WITH NOWAIT;
RAISERROR(N'Collected %I64d server properties row(s)', 0, 1, @rows_collected) WITH NOWAIT;

SELECT TOP (1)
sp.server_name,
Expand Down
Loading