Missing PVs since 3.2.0

[nariox]

Hello all,

I am facing a rather minor issue since a recent upgrade. Particularly, since upgrading to iocStats 3.2.0 (from 3.1.16), some of the PVs previously hard-coded in one of the substitutions files (HERE) is now auto generated by scanning CONFIG_SITE_ENV (see HERE).

The issue that arose from this is that the PV pointing to EPICS_IOC_LOG_PORT is no longer generated. I have posted in epics-base asking whether it would make more sense to simply move EPICS_IOC_LOG_PORT to CONFIG_SITE_ENV (link HERE), since it already contains several related variables (EPICS_IOC_LOG_INET, EPICS_IOC_LOG_FILE_NAME, EPICS_IOC_LOG_FILE_COMMAND and EPICS_IOC_LOG_FILE_LIMIT), but for the time being, I think we should include it in epicsEnvVars.substitutions.

[simon-ess]

Linked EPICS base issue epics-base/epics-base#728 and PR epics-base/epics-base#729

[simon-ess]

The suggestion to use CONFIG_ENV as well as CONFIG_SITE_ENV is promising, since that includes the environment variables specified here anyhow: https://github.com/epics-modules/iocStats/blob/master/iocAdmin/Db/epicsEnvVars.substitutions

[nariox]

Hi Simon,

the only problem is that this would break compatibility with existing screens. I don't know exactly why originally epicsEnvVars.substitutions did this, but the PV names and the environment variable names are not the same for most of them (basically all other than CAS_BEACON_PERIOD and CAS_BEACON_PORT). One alternative, would be to create a supplemental db file that creates aliases for the relevant PVs (this would also allow us to alias TIMEZONE -> TZ PV).

If that seems like a reasonable solution to you, I could create a PR for it, then the user could selectively create the aliases for backwards compatibility with older screens or just move forward with the new PV naming convention (greenfield approach). What do you think?

EDIT.: I forgot to list the naming changes. Here they are:

PV Name -> Env var
CA_ADDR_LIST -> CA_ADDR_LIST             
CA_CONN_TIME -> CA_CONN_TMO              
CA_AUTO_ADDR -> CA_AUTO_ADDR_LIST        
CA_RPTR_PORT -> CA_REPEATER_PORT         
CA_SRVR_PORT -> CA_SERVER_PORT           
CA_MAX_ARRAY -> CA_MAX_ARRAY_BYTES       
CA_SRCH_TIME -> CA_MAX_SEARCH_PERIOD     
CA_BEAC_TIME -> CA_BEACON_PERIOD         

CAS_SRVR_PORT -> CAS_SERVER_PORT          
CAS_AUTO_ADDR -> CAS_AUTO_BEACON_ADDR_LIST
CAS_ADDR_LIST -> CAS_BEACON_ADDR_LIST     
CAS_BEACON_PERIOD -> CAS_BEACON_PERIOD        
CAS_BEACON_PORT -> CAS_BEACON_PORT          
CAS_ADDR_INTF_LIST -> CAS_INTF_ADDR_LIST       
CAS_ADDR_IGNORE_LIST -> CAS_IGNORE_ADDR_LIST     

[nariox]

Hi Simon,

I went ahead and wrote a PR for this (and a minor fix) -> #70
Let me know what you think. If it looks good to you, we can close this.