Redis incremented by 0

[balous]

I am wondering why ratelimit can send zero increment requests to redis database.

When getHitsAddend() returns zero, for example when STOP_CACHE_KEY_INCREMENT_WHEN_OVERLIMIT and the counter is over limit, ratelimit sends INCRBY(0) request to redis. Such a behavior is even verified by unit tests so I think this must have been made intentionally.

I'd guess that the purpose of STOP_CACHE_KEY_INCREMENT_WHEN_OVERLIMIT is to avoid unnecessary load on redis but zero increments make redis load too.

So what is the purpose? Anyone knows?

[github-actions]

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

[github-actions]

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.