fix(miner): retain unmarked send cache#354
Open
JSONbored wants to merge 2 commits into
Open
Conversation
Keep unmarked destination-send records when a transient poll miss drops a swap from the active set, so rediscovered swaps retry mark_fulfilled instead of broadcasting destination funds again. Add regression coverage for stale send cleanup and poller-miss rediscovery.
Collaborator
|
Can you give this a quick rebase on |
Contributor
Author
Done! Thanks 🙌🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
A transient contract/indexer read gap can make the miner poller drop an active swap after repeated
get_swap()misses. The miner then callscleanup_stale_sends()with the reduced active set. If that cleanup deletes an unmarked cached destination tx, a later rediscovered swap can broadcast destination funds again instead of retryingmark_fulfilledfor the original tx.Closes #353.
Validation
uv run pytest tests/test_fulfillment.py tests/test_swap_poller.py -quv run pytest tests/ -quv run ruff check .uv run ruff format --check .git diff --checkNotes
The duplicate check found no open issue or PR for this exact
cleanup_stale_sends/ unmarked send-cache failure mode before publication.