Extra help?

[fdosani]

Hi Tom,

First off this is a great package! Thanks so much for creating it.
Wondering if you'd be open to some help or extra maintainers for the project? I'd like to help out if you were open to it in terms of PRs, code reviews, or adding additional features. No worries either way, just hoping to help if possible and keep this great project going.

Thanks and Happy holidays!

[TomAugspurger]

Thanks for the offer. I'll look into making an engarde-dev organization and moving things over there.

cc @topper-123 if you'd be interested as well.

[topper-123]

Hey, I'm currently exclusively using pandas.util.testing together with pytest, so I'm not currently using Engarde...

I could be a backup guy of sorts if you need it though. It is a nice package :-)

[alysivji]

@topper-123 do you have any open source examples of the things you are doing?

Always curious to see how folks test in the data science / data engineering space

[ZaxR]

I'd be open to helping maintain as well, or at least contributing (just sent over a small PR actually).

[drosengarten]

Please setup an engarde-dev organizational. I am willing to help and want to make several improvements. I have emailed you and would prefer to enhance engarde instead of forking it.

[TomAugspurger]

Moved to https://github.com/engarde-dev/engarde and invited. LMK if you run into other blockers.

[TomAugspurger]

Possibly CI things like travis / readthedocs. Not sure if they inherit permissions from GitHub.

[drosengarten]

Thanks. My changes will include adding the has_columns, added the ability to check input parameters or index of an function return argument. Also made it disable-able, and added Eval checks. I need to work with my company to make the changes.

[fdosani]

Thanks @TomAugspurger for setting this up.

In terms of ongoing work do you have a certain direction you want the package to go? Just want to make sure we don't deviate too much from your vision.

[ZaxR]

Thanks @TomAugspurger for all the effort. When I didn't hear back I ended up creating a new library called Bulwark (and crediting your influence :) ). It has some changes to the backend, some new tests, and slightly different check names, but largely a continuation of all the work you did. Given that Bulwark has some active users/contributors at this point, I think I will continue to work on that project, but sounds like you have a couple of other great volunteers here. If you're interested in checking out Bulwark:

GitHub: https://github.com/ZaxR/bulwark
PyPi: https://pypi.org/project/bulwark/
Docs: https://bulwark.readthedocs.io/en/latest/

[fdosani]

@TomAugspurger Seems like I might only have read access. Was trying to setup Travis and push to a branch in engarde-dev but can't. No biggie. Will just work off a fork, but suspect that tests won't run?

[TomAugspurger]

When I didn't hear back I ended up creating a new library called Bulwark

Sorry about that (and nice name 😀). Is it worth trying to move people to bulwark?

[ZaxR]

No worries at all. The only blocker to moving people to Bulwark would be that I dropped python 2 support (in line with the direction of pandas itself). If it’s important to the engarde user base, I’m open to adding that back, though. Should only take a day to do.

Migration would be as simple as changing the word engarde to bulwark in many cases, with a few that would just need a tweak to the function name (old names could be added with a deprecation warning to help people out).

Let me know what you think.

[TomAugspurger]

I'm happy to leave that decision to others in this thread. I don't really have a horse in this race.

…

On Fri, Jul 26, 2019 at 8:06 AM Zax ***@***.***> wrote: No worries at all. The only blocker to moving people to Bulwark would be that I dropped python 2 support (in line with the direction of pandas itself). If it’s important to the engarde user base, I’m open to adding that back, though. Should only take a day to do. Migration would be as simple as changing engarde to bulwark in many cases, with a few that would just need a tweak to the function name (old names could be added with a deprecation warning to help people out). Let me know what you think. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#56?email_source=notifications&email_token=AAKAOIR3I2IHNUVYK5FTW3LQBLZFPA5CNFSM4GL6BDA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD24QXTA#issuecomment-515443660>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAKAOIVHKY3POMWOQOVOEILQBLZFPANCNFSM4GL6BDAQ> .

[TomAugspurger]

@alysivji @fdosani thoughts on migrating / directing people to bulwark?