Skip to content

El Abrigo references files from Champ #2210

@wjt

Description

@wjt

Threadbare version

7ec969a

Affected scene

scenes/quests/story_quests/el_abrigo/2_el_abrigo_stealth/el_abrigo_stealth1.tscn

Description

StoryQuests are meant to be self-contained, in the sense that there should be no references to files in a storyquest from outside that storyquest's folder.

I happened to notice today that El Abrigo references files from Champ:

$ git grep res://scenes/quests/story_quests/champ ':!scenes/quests/story_quests/champ'
scenes/quests/story_quests/el_abrigo/2_el_abrigo_stealth/el_abrigo_stealth1.tscn:4:[ext_resource type="TileSet" uid="uid://cbbshdkxebjh6" path="res://scenes/quests/story_quests/champ/tiles/champ_exterior_floors.tres" id="2_ns4g4"]
scenes/quests/story_quests/el_abrigo/2_el_abrigo_stealth/el_abrigo_stealth1.tscn:5:[ext_resource type="TileSet" uid="uid://djck8217try86" path="res://scenes/quests/story_quests/champ/tiles/champ_elevation.tres" id="3_akp4c"]

It also contains a number of files whose names contain champ, which is confusing:

$ find scenes/quests/story_quests/el_abrigo -name '*champ*'
scenes/quests/story_quests/el_abrigo/2_el_abrigo_stealth/el_abrigo_stealth1components/champ_guard_enemy_alerted.png
scenes/quests/story_quests/el_abrigo/2_el_abrigo_stealth/el_abrigo_stealth1components/champ_guard_enemy_idle.png
scenes/quests/story_quests/el_abrigo/2_el_abrigo_stealth/el_abrigo_stealth1components/champ_guard_enemy_walk.png
scenes/quests/story_quests/el_abrigo/2_el_abrigo_stealth/el_abrigo_stealth1components/champ_checkpoint.dialogue
scenes/quests/story_quests/el_abrigo/2_el_abrigo_stealth/el_abrigo_stealth1components/champ_collected.dialogue
scenes/quests/story_quests/el_abrigo/2_el_abrigo_stealth/el_abrigo_stealth1components/champ_stealth.dialogue
scenes/quests/story_quests/el_abrigo/2_el_abrigo_stealth/el_abrigo_stealth1components/champ_guard_enemy.tres
scenes/quests/story_quests/el_abrigo/2_el_abrigo_stealth/el_abrigo_stealth1components/champ_stealth.dialogue.import
scenes/quests/story_quests/el_abrigo/2_el_abrigo_stealth/el_abrigo_stealth1components/champ_collected.dialogue.import
scenes/quests/story_quests/el_abrigo/2_el_abrigo_stealth/el_abrigo_stealth1components/champ_checkpoint.dialogue.import
scenes/quests/story_quests/el_abrigo/2_el_abrigo_stealth/el_abrigo_stealth1components/champ_guard_enemy_walk.png.import
scenes/quests/story_quests/el_abrigo/2_el_abrigo_stealth/el_abrigo_stealth1components/champ_guard_enemy_idle.png.import
scenes/quests/story_quests/el_abrigo/2_el_abrigo_stealth/el_abrigo_stealth1components/champ_guard_enemy_alerted.png.import

Checklist

  • I've reviewed and agree to follow the code of conduct

Metadata

Metadata

Assignees

No one assigned

    Labels

    StoryQuestNew StoryQuests or updates to existing ones

    Type

    No fields configured for Bug.

    Projects

    Status

    Untriaged

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions