Non-blocking follow-up item flagged during review of #165 but not addressed before merge.
Metrics::default() diverges from Metrics::new()
The auto-derived Metrics::default() still exists but no longer pre-seeds the known channels, so it diverges from Metrics::new(). Every call site currently uses ::new(), so this is fine today — but a future contributor could trip on it.
Suggestion: either add a short doc comment on Metrics::new() calling out "prefer this over default()", or remove the #[derive(Default)] if it isn't needed elsewhere.
Source: review comment on #165
Related: #165 (merged)
Non-blocking follow-up item flagged during review of #165 but not addressed before merge.
Metrics::default()diverges fromMetrics::new()The auto-derived
Metrics::default()still exists but no longer pre-seeds the known channels, so it diverges fromMetrics::new(). Every call site currently uses::new(), so this is fine today — but a future contributor could trip on it.Suggestion: either add a short doc comment on
Metrics::new()calling out "prefer this overdefault()", or remove the#[derive(Default)]if it isn't needed elsewhere.Source: review comment on #165
Related: #165 (merged)