Column preview gets cut off

[danirabbit]

What Happened?

Column preview can be cut off such that the preview and information is not fully shown

Steps to Reproduce

Have several columns open such that the preview is the last column

Expected Behavior

• The preview should probably be homogeneous in size with the other columns or have some kind of minimum size
• Text in the column should wrap so that it's not cut off
• Image previews should shrink to fill the width of the column

OS Version

8.x (Circe)

OS Architecture

amd64 (on most hardwares)

Session Type

Secure Session (Wayland, This is the default)

Software Version

Compiled from git

Log Output

Hardware Info

No response

[jeremypw]

Could this be split into two issues - one regarding scrolling and one regarding resizing the preview? Thanks. I am pushing a fix for the scrolling issue now.

[jeremypw]

@danirabbit If the scrolling is fixed so that the preview widget scrolls completely into view does this fix the problem? The current intention is that the preview widget behaves much like a directoryview slot in that it has a preferred width and scrolls fully into view when active. However it is not intended to resize manually at the moment. Fixing that would require modifying the widget itself in a separate PR. With all the nested Gtk.Paned widgets it is quite tricky to get this right. I am having a look at putting the preview widget in a separate box or paned (common to all slots via AbstractSlot) rather than to the stack of nested slots. This should have less impact on the Column View widget. This would also make it easier to implement preview in other views in future. I am not too sure about wrapping and image resizing tbh - the preview is intended to give a accurate impression, better than a thumbnail. However, it should be possible to make the PREVIEW_SIZE constant into a property which could be related to the available space, resolution or and user preference.

[danirabbit]

@jeremypw the main problem is that the pane can be resized such that some of its content is hidden. Scrolling to the end wouldn't fix the issue because you can't scroll to content that is truncated by the pane itself

Having the pane widget in a separate box at the end of the view would be a good idea, I think.

I think it should be resizable like the way it is in Music, but this might be tricky in GTK3 and could wait for GTK4. We might instead have to make this image preview size smaller though. It's quite large. On smaller screens you would never even be able to see most of its content. Keep in mind these are scrolled to the right as far as you can and there's no way to resize so that the content becomes visible if you're on a small screen:

[jeremypw]

I didn't see that as a problem particularly as it under the user's control - directory slots also are truncated if manually resized; they dont change the font size or wrap either. As long as it scrolls into view when active, like other slots.

I agree that the preview size should adapt according the screen size and/or the window size. Column View tends to assume there is a reasonable width available. but the preview takes the space of two or more columns which is probably too much for small screens.

I am also trying to make the details widget persist with a stable width rather destroying and rebuilding it all the time which causes a visual glitch.

[danirabbit]

@jeremypw that's the problem though is that it's only under the user's control on a large screen. On small screens it's not possible to resize the window to show the pane. It will just be cut off with no way to get to it because it can't be scrolled to

[jeremypw]

#2714 should fix most of the issues apart from the widget not being resizable - the space it takes up can be reduced though it just gets truncated. Without a resizable image widget there is not much to be done.