Skip to content

Correct handling of '-s'/'-n' flag when adding inlimit using ecflow_client ECFLOW-2094#344

Open
marcosbento wants to merge 2 commits into
developfrom
fix/inline_flags_alter_add
Open

Correct handling of '-s'/'-n' flag when adding inlimit using ecflow_client ECFLOW-2094#344
marcosbento wants to merge 2 commits into
developfrom
fix/inline_flags_alter_add

Conversation

@marcosbento
Copy link
Copy Markdown
Collaborator

@marcosbento marcosbento commented May 22, 2026

Description

As per PR title.

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

🌦️ >> Documentation << 🌦️
https://sites.ecmwf.int/docs/dev-section/ecflow/pull-requests/PR-344

@marcosbento marcosbento force-pushed the fix/inline_flags_alter_add branch from f179d56 to f4ec0da Compare May 24, 2026 06:08
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.68519% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.65%. Comparing base (1871903) to head (f4ec0da).

Files with missing lines Patch % Lines
libs/test/foolproof/TestFoolproof.InLimit.cpp 96.73% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #344      +/-   ##
===========================================
+ Coverage    50.57%   50.65%   +0.08%     
===========================================
  Files         1237     1238       +1     
  Lines        98653    98819     +166     
  Branches     14958    14955       -3     
===========================================
+ Hits         49890    50057     +167     
+ Misses       48763    48762       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants