Skip to content

Wmo paramids#62

Open
simondsmart wants to merge 9 commits into
mainfrom
wmo-paramids
Open

Wmo paramids#62
simondsmart wants to merge 9 commits into
mainfrom
wmo-paramids

Conversation

@simondsmart
Copy link
Copy Markdown
Contributor

Description

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

Comment thread MARS language/MARS-008-WMO-Units.md Outdated
Comment thread MARS language/MARS-008-WMO-Units.md Outdated
Comment thread MARS language/MARS-008-WMO-Units.md Outdated
Comment thread MARS language/MARS-008-WMO-Units.md Outdated
Comment thread MARS language/MARS-008-WMO-Units.md Outdated
Comment thread MARS language/MARS-008-WMO-Units.md Outdated
Comment thread MARS language/MARS-008-WMO-Units.md
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new MARS language decision record describing how to handle short-name ambiguity for new WMO-unit paramids (including an explicit units= post-processing keyword concept), and updates the MARS language ADR index/statuses accordingly.

Changes:

  • Mark MARS-007 as Accepted in both the index and the decision record status line.
  • Add new decision record MARS-008 (“WMO Units”) proposing an approach for short-name handling and on-the-fly unit coercion.
  • Add MARS-008 to the MARS language README index.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File Description
MARS language/README.md Updates the ADR index to reflect MARS-007 acceptance and add MARS-008.
MARS language/MARS-007-Timespan-Absence.md Updates the ADR status line to Accepted.
MARS language/MARS-008-WMO-Units.md Introduces a new ADR proposing handling/UX for WMO-unit paramid transitions and a units= concept.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread MARS language/MARS-008-WMO-Units.md Outdated
Comment thread MARS language/MARS-008-WMO-Units.md Outdated
Comment thread MARS language/MARS-008-WMO-Units.md Outdated
Comment thread MARS language/MARS-008-WMO-Units.md Outdated
Comment thread MARS language/MARS-008-WMO-Units.md Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants