Skip to content

Import https://github.com/snjeza/bazel-ls-demo-project/tree/master/large #16

@snjeza

Description

@snjeza

Related issues:

I have started with https://github.com/eclipseguru/bazel-eclipse/tree/performance, commit 8a6f0db bazel-eclipse, the main branch and tried to import large to Eclipse using Bazel Eclipse Feature (BEF)

There are several issues:

  1. The project has been created for Bazel 5, but IntelliJ aspects require Bazel>= 6
    I have updated the project to work with Bazel 6.1.0. so that now IntelliJ aspects run correctly.

  2. The project uses java/resources references that aren’t usual for Bazel - Bazel Eclipse doesn't recognize filegroup #15 (comment)
    I have replaced them with resources.

  3. I have added the PR Bazel Eclipse doesn't recognize filegroup #15

When I try to import a project, that takes a long time or Eclipse freezes.

  1. Bazel Eclipse refreshes projects on
    that causes it to repeatedly try to configure projects.

I have commented this call. The Sync Bazel Projects View action happens in the workspace job. Eclipse will automatically refresh projects when the job is finished.

@guw Is there any special reason to call refreshLocal within the workspace job?

  1. The findProject method is still called multiple times for the same package/target.

  2. JvmConfigurator will dispose and recreate VM every time the Sync Bazel Projects View action is called.

This is a patch against the https://github.com/eclipseguru/bazel-eclipse/tree/performance branch
If the patch is included, importing https://github.com/snjeza/bazel-ls-demo-project/tree/master/large will take about 10 minutes

@guw I would suggest you to apply your #13.
After that, I will create a PR for the issues described in this issue.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions