ExposedThing handleUnsubscribeEvent and handleUnobserveProperty should be async

[danielpeintner]

In ExposedThing we have

node-wot/packages/core/src/exposed-thing.ts

Line 575 in 8dc6ed8

public handleUnsubscribeEvent(

and

node-wot/packages/core/src/exposed-thing.ts

Line 642 in 8dc6ed8

public handleUnobserveProperty(

Both are not async while the counterpart of handleSubscribeEvent and handleObserveProperty are async.
Both call async functions (unsubscribe/unobserveHandler)

I think we ought to change them. Opinions?

[erossignon]

I see your point, There are situation in the code where we mistakely miss the await keyword.

for instance

node-wot/packages/binding-http/test/http-server-test.ts

Line 173 in 8dc6ed8

testThing.handleSubscribeEvent(

All async method should be called with await keyword before , unless they explicitily need to be run in parallel of the main loop (in this case we use the foo().then().catch() pattern) and we need to enfore this rule in the linter. (this is addressed in #1446 )

Having some sort of symetry would help too, even though the linter might complain that an async method could be turned into a no-async method if it doesn't call a async method itself.

Shall we rely on the linter only ?

[danielpeintner]

Shall we rely on the linter only ?

I hope that's enough. I found the problem with #1446

[Pranav-0440]

Thanks for the discussion.

I’ve updated both handleUnsubscribeEvent and handleUnobserveProperty to:

• Mark them as async
• Change return type to Promise<void>
• Await the corresponding unsubscribe / unobserveHandler callbacks

This ensures symmetry with handleSubscribeEvent and handleObserveProperty, and avoids potential floating promises (aligned with the linter rule from #1446).
Build and full test suite pass locally.

PR: #1480