What Repos are considered for generating the Acknowledgement Page`

[BeckerWdf]

As far as I understand .github/workflows/generateAcknowledgements.yml does generate the Acknowledgement Page for the releases (e.g. https://eclipse.dev/eclipse/markdown/?f=news/4.39/acknowledgements.md).

Which repos are taken into account?

I would propose to also include changes to the https://github.com/eclipse-platform/ui-best-practices.

[akurtakov]

It's done via https://github.com/eclipse-platform/www.eclipse.org-eclipse/blob/master/.github/workflows/generateAcknowledgements.yml IIRC

[BeckerWdf]

So the list of repos is basically in https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/blob/master/.gitmodules

Can we simply add the https://github.com/eclipse-platform/ui-best-practices repo there?

[akurtakov]

Should be possible. One can try to modify in his own fork and figure it out.

[BeckerWdf]

Should I propose a PR?

[akurtakov]

Yes, please. If a repo is part of the project we should acknowledge contributions to it.

[BeckerWdf]

Yes, please. If a repo is part of the project we should acknowledge contributions to it.

Done.

[akurtakov]

I have closed the PR as having it this repo cloned everytime/place where releng.aggregator is -is way too wasteful. Please adjust the GHA instead.

[HannesWell]

I have closed the PR as having it this repo cloned everytime/place where releng.aggregator is -is way too wasteful. Please adjust the GHA instead.

Just to repeat my answer form that PR:
Instead the acknowledgement-workflow should be adjusted to consider that repository too.
Or it should be reworked to just traverse all active repositories of the known eclipse top-level organizations.

The later could even make the 'collection' part of the workflow simpler.
@BeckerWdf do you want to have a look at that or do you need help?

[HannesWell]

I have closed the PR as having it this repo cloned everytime/place where releng.aggregator is -is way too wasteful. Please adjust the GHA instead.

Just to repeat my answer form that PR:
Instead the acknowledgement-workflow should be adjusted to consider that repository too.
Or it should be reworked to just traverse all active repositories of the known eclipse top-level organizations.

The later could even make the 'collection' part of the workflow simpler.
@BeckerWdf do you want to have a look at that or do you need help?

[laeubi]

I'm not totally sure it makes sense... As Tycho is "contributing" to the release as well, should it be listed then consequently also? What about EMF, ECF, Orbit, JustJ, ...? Maybe Maven, Adoptium, ...? What about JUnit and similar 3rd party dep?

So I would say, if an icon is changed, and the user push it to the repo it will be show on the page as-is. If we absolutely want that a static acknowledgement like for the it infra staff seems more suitable to me and then we should make this list even longer (see above).

[BeckerWdf]

The later could even make the 'collection' part of the workflow simpler.
@BeckerWdf do you want to have a look at that or do you need help?

I think I don't have the knowledge to do that. So help would be needed.

[BeckerWdf]

I'm not totally sure it makes sense... As Tycho is "contributing" to the release as well, should it be listed then consequently also?

This is a different question. The repo mentioned by me is a part of the platform project. And why should be not acknowledge contributions to it. Are contributions only important if the find their way into the binary we deliver directly?