Adding a copy processor for file/folder resources

[Felix-Schmid]

Hello everyone,

In the Eclipse 4diac IDE, we implemented our own copy processor to enable copy participants that can refactor files during copy operations. You can find it here: FordiacCopyProcessor.java.

We’re interested in upstreaming a similar processor so other Eclipse projects can benefit as well. There already appears to be a copy processor in LTK that was added here: #2262. However, that implementation applies only to copying projects, whereas ours also handles files and folders.

We’d like to gain some insight into why the existing approach focuses on projects and whether there were reasons a file/folder copy processor was not included. It’s possible there are considerations we’ve missed.

Furthermore, we’d like to discuss whether we should:

• Add a new copy processor that supports files and folders, or
• Extend the existing implementation beyond projects to handle files and folders as well.

We’re happy to provide more details or open a PR. Thank you for your time and feedback.

[vogella]

Sounds good to me. Add a new processor, do not extend CopyProjectProcessor. That class is project-specific and the LTK pattern seem to be one processor per resource scope: RenameResourceProcessor vs RenameProjectProcessor.

We are close to a release freeze for 4.40 so if you provide a PR it will most likely not land in 4.40 (at least not by me).

[Felix-Schmid]

OK, thanks for the quick reply. I’ll create a PR as soon as everything’s ready.
It’s absolutely fine if it doesn’t make it into version 4.40, it’s not that urgent for us.