Skip to content

Wait for process to terminate in InstanceMainMethodsTests #954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trancexpress merged 1 commit into from
May 17, 2026
Merged

Wait for process to terminate in InstanceMainMethodsTests #954

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions ...jdt.debug.tests/tests/org/eclipse/jdt/debug/tests/launching/InstanceMainMethodsTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@
import org.eclipse.jdt.core.IJavaProject;
import org.eclipse.jdt.debug.core.IJavaDebugTarget;
import org.eclipse.jdt.debug.tests.AbstractDebugTest;
import org.eclipse.jdt.debug.tests.TestUtil;
import org.eclipse.swt.widgets.Display;

public class InstanceMainMethodsTests extends AbstractDebugTest {

Expand All @@ -41,8 +43,7 @@ public void testStaticMainWithoutArgs() throws Exception {
terminateAndRemove(target);
}
}
assertNotNull("Missing VM process.", process);
assertEquals("Process finished with error code", 0, process.getExitValue());
waitForExit(process, 10_000L);
}

public void testDefaultMainWithoutArgs() throws Exception {
Expand All @@ -57,7 +58,18 @@ public void testDefaultMainWithoutArgs() throws Exception {
terminateAndRemove(target);
}
}
waitForExit(process, 10_000L);
}

private static void waitForExit(IProcess process, long timeoutMs) throws Exception {
assertNotNull("Missing VM process.", process);
long start = System.currentTimeMillis();
while (!process.isTerminated() && System.currentTimeMillis() - start < timeoutMs) {
if (Display.getCurrent() != null) {
TestUtil.runEventLoop();
}
Thread.sleep(50L);
}
assertEquals("Process finished with error code", 0, process.getExitValue());
}

Expand Down
Loading