TheiaBackendModelServerClientV2.edit() does not work with CompoundCommand

[kubomann]

Hi.
(I couldn't find a suitable category, so I'm posting to All Other.)

I am currently developing with Modelserver Theia integration(eclipse-emfcloud/emfcloud-modelserver-theia).
TheiaModelServerClientV2.edit() worked if I set the SetCommand as an argument.
However, it didn't work if I included SetCommand in CompoundCommand and set CompoundCommand as an argument.

TheiaBackendModelServerClientV2.edit() is implemented as follows:

    edit(modeluri: URI, patchOrCommand: PatchOrCommand, format?: Format): Promise<ModelUpdateResult> {
        if (ModelServerCommand.is(patchOrCommand)) {
            return super.edit(modeluri, ensureCommandPrototype(patchOrCommand));
        }
        return super.edit(modeluri, patchOrCommand, format);
    }

I think the reason is that ModelServerCommand.is() is false for CompoundCommand. Is this a bug?

[ndoschek]

Hi @kubomann,

Thank you for catching that!
I had a look and I would agree that this is a bug.
The if clause should check for both command types (e.g. like if (ModelServerCommand.is(patchOrCommand) || CompoundCommand.is(patchOrCommand))).

Would you mind opening an issue in the emfcloud-modelserver-theia repository, as you found it 🐛
We would also gladly accept a contribution to get this fixed :)

Thanks and BR,
Nina

[kubomann]

Hi @ndoschek .

Thank you for your answer.
I have opened an issue /eclipse-emfcloud/emfcloud-modelserver-theia#144 .

[ndoschek]

Great, thank you! 👍