Missing fields in some JSON Schema files that are present in examples

[mario-tin]

In the JSON Schema defined in the file artifacts/src/main/resources/catalog/dataset-schema.json:

• The 'Dataset' definition does not have a property "@type": "Dataset".
• The 'Distribution' definition does not have a property "@type": "Distribution".

But in the examples in the file artifacts/src/main/resources/catalog/example/dataset.json, the root object have a field "@type": "Dataset", and the objects in the JSON array "distribution" also have a field "@type": "Distribution". And you can find those same fields in the file example/catalog.json.

The JSON Schema specification and the examples are not consistent.

[arnoweiss]

The schemas are open to additional properties. Thus having unspecified properties like @type in the examples is not a violation of the schemas - we check for that automatically with every commit to main. There's a point to be made on if the spec should have unspecified properties in the examples, though. Do you have a functional issue that is related to this?

[mario-tin]

The issue I'm reporting isn't really because I believe there's a violation of the schemas, but because I think the specification would be more consistent and that all important objects should have a @type field, rather than just some having them and others not. That's why the examples seem fine to me.

[ssteinbuss]

This is editorial. We plan to include this in one of the next releases.

[jmcanterafonseca-iota]

The issue I'm reporting isn't really because I believe there's a violation of the schemas, but because I think the specification would be more consistent and that all important objects should have a @type field, rather than just some having them and others not. That's why the examples seem fine to me.

yes definitely, the @type should be required for the key objects