Skip to content

Commit 92acbbc

Browse files
[cross-repo from workflow#682] Conformance blocker: complete replay parity coverage beyond smoke (#178)
1 parent eba1752 commit 92acbbc

3 files changed

Lines changed: 6 additions & 3 deletions

File tree

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
3030
`NamespaceDescription.deleted`.
3131

3232
### Fixed
33+
- `durable-workflow-replay-conformance` now declares `outcome: pass` when
34+
every required Python replay shard scenario passes, so full replay evidence
35+
is no longer reported as non-passing.
3336
- Worker query tasks now treat null or empty compact history payload fields as
3437
missing when a history export carries the durable activity result or signal
3538
arguments, so cold replay after worker restart does not answer queries from

src/durable_workflow/replay_conformance.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,7 @@ def compose_report(
247247
"schema": RESULT_SCHEMA,
248248
"schema_version": RESULT_VERSION,
249249
"coverage_scope": COVERAGE_SCOPE,
250-
"outcome": "fail" if has_failures else "non_passing",
250+
"outcome": "fail" if has_failures else "pass",
251251
"started_at": started_at,
252252
"finished_at": _timestamp(),
253253
"artifact_versions": versions,

tests/test_replay_conformance.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ def test_compose_report_emits_python_replay_conformance_shard() -> None:
5050
assert report["schema"] == RESULT_SCHEMA
5151
assert report["schema_version"] == RESULT_VERSION
5252
assert report["coverage_scope"] == COVERAGE_SCOPE
53-
assert report["outcome"] == "non_passing"
53+
assert report["outcome"] == "pass"
5454
assert report["runtime_matrix"]["runtimes"] == ["sdk-python"]
5555
assert report["artifact_versions"]["workflow-php"] == "2.0.0-alpha.175"
5656
assert report["artifact_sources"]["workflow-php"] == "composer_package"
@@ -197,7 +197,7 @@ def test_cli_writes_json_report(tmp_path: Path) -> None:
197197
payload = json.loads(output_path.read_text())
198198
assert payload["schema"] == RESULT_SCHEMA
199199
assert payload["coverage_scope"] == COVERAGE_SCOPE
200-
assert payload["outcome"] == "non_passing"
200+
assert payload["outcome"] == "pass"
201201

202202

203203
def test_cli_exits_nonzero_when_required_artifact_evidence_is_missing(tmp_path: Path) -> None:

0 commit comments

Comments
 (0)