Skip to content
This repository was archived by the owner on Sep 12, 2024. It is now read-only.
This repository was archived by the owner on Sep 12, 2024. It is now read-only.

Always raise a more specific exception than Exception #95

@richcooper95

Description

@richcooper95

Describe the bug
In some places, Exception is raised - this isn't good practice as it makes it almost impossible for the users of the library to catch this specific exception without hiding bugs - see discussion here.

To Reproduce
n/a

Expected behavior
It’s much better to define a custom Exception class, or use one of the built-ins (e.g. RuntimeError).

Examples around here - in this case, InvalidResponseError might be a better exception type.

System (please complete the following information):
n/a

Additional context
n/a

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions