Skip to content

Support pixel privacy review automation#33

Merged
ladamski merged 4 commits into
mainfrom
la/expose-privacy-review-outputs
May 25, 2026
Merged

Support pixel privacy review automation#33
ladamski merged 4 commits into
mainfrom
la/expose-privacy-review-outputs

Conversation

@ladamski
Copy link
Copy Markdown
Collaborator

@ladamski ladamski commented May 14, 2026

https://app.asana.com/1/137249556945/project/1205243787707480/task/1214512208674130?focus=true

The composite action runs create-asana-task, which sets a taskId output on its inner step. Callers (per-repo privacy-review.yml workflows) had no way to read this — composite actions don't propagate inner step outputs unless declared. Expose them now so callers can chain follow-up automation like dispatching the AI Privacy Review classifier in duckduckgo/privacy-review-automation.

  • triage_task_id: GID of the Privacy Triage task this action just created
  • triage_task_permalink: built from the hardcoded project + the GID
  • original_task_id: GID matched from the PR description by find-asana-task-id

No behavior change inside the action itself; outputs only.

After merging, cut a new tag (eg. v2.4) so per-repo workflows can pin to the version that exposes these outputs.


Note

Medium Risk
Introduces a new cross-repo workflow_dispatch call that depends on github_pat permissions and a non-main workflow ref, which could trigger unintended automation if misconfigured.

Overview
After creating the Asana privacy triage task, the composite action now dispatches the privacy-review-classifier.lock.yml workflow in duckduckgo/privacy-review-automation, passing pr_url and the created privacy_triage_task_id.

Also bumps this package/action version from 1.3.0 to 2.4.0 in package.json and package-lock.json.

Reviewed by Cursor Bugbot for commit 12bd807. Bugbot is set up for automated code reviews on this repo. Configure here.

ladamski and others added 2 commits May 14, 2026 09:02
…l_task_id

The composite action runs create-asana-task, which sets a `taskId` output
on its inner step. Callers (per-repo privacy-review.yml workflows) had no
way to read this — composite actions don't propagate inner step outputs
unless declared. Expose them now so callers can chain follow-up automation
like dispatching the AI Privacy Review classifier in
duckduckgo/privacy-review-automation.

- triage_task_id: GID of the Privacy Triage task this action just created
- triage_task_permalink: built from the hardcoded project + the GID
- original_task_id: GID matched from the PR description by find-asana-task-id

No behavior change inside the action itself; outputs only.

After merging, cut a new tag (eg. v2.4) so per-repo workflows can pin to
the version that exposes these outputs.

Co-authored-by: Cursor <cursoragent@cursor.com>
@ladamski ladamski changed the title privacy-review: expose triage_task_id, triage_task_permalink, origina… Support pixel privacy review automation May 14, 2026
Copy link
Copy Markdown
Collaborator

@nshuba nshuba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but looks like there's a lint failure

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 79e3a27. Configure here.

Comment thread .github/actions/privacy-review/action.yml
@nshuba nshuba self-requested a review May 18, 2026 21:44
Comment thread .github/actions/privacy-review/action.yml Outdated
@ladamski ladamski merged commit c81bf88 into main May 25, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants