Skip to content

build(deps-dev): bump web-ext to remove stale ajv#2711

Draft
cursor[bot] wants to merge 4 commits into
mainfrom
jkt/auto/dependency-update-review-3dad
Draft

build(deps-dev): bump web-ext to remove stale ajv#2711
cursor[bot] wants to merge 4 commits into
mainfrom
jkt/auto/dependency-update-review-3dad

Conversation

@cursor
Copy link
Copy Markdown
Contributor

@cursor cursor Bot commented May 22, 2026

Asana Task/Github Issue: Follow-up to dependency review for #2674

Description

Bumps web-ext to 10.2.0 so its addons-linter dependency resolves to 10.5.0, which pins ajv@8.20.0 and removes the nested addons-linter/node_modules/ajv@8.18.0 copy left by the direct ajv update.

Also updates the fake MV3 integration-test extension manifest with required Firefox metadata so the newer linter passes cleanly.

Testing Steps

  • npm ls ajv --all
  • npx web-ext lint --source-dir=integration-test/extension from injected/
  • npm run test-unit --workspace=injected -- --random=false --filter='test-pages'

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged
Open in Web View Automation 

Note

Low Risk
Low risk: dependency bumps and test-only manifest metadata updates; main risk is CI/lint behavior changes due to updated web-ext/addons-linter toolchain.

Overview
Updates the dev tooling by bumping web-ext to 10.2.0 (and ajv to ^8.20.0 at the root), which refreshes transitive linter dependencies and removes older nested ajv copies in the lockfile.

Adjusts the MV3 fake integration-test extension manifest.json to include Firefox browser_specific_settings.gecko metadata so web-ext lint passes with the newer linter.

Reviewed by Cursor Bugbot for commit 43589a8. Bugbot is set up for automated code reviews on this repo. Configure here.

dependabot Bot and others added 3 commits May 22, 2026 09:40
Bumps [ajv](https://github.com/ajv-validator/ajv) from 8.18.0 to 8.20.0.
- [Release notes](https://github.com/ajv-validator/ajv/releases)
- [Commits](ajv-validator/ajv@v8.18.0...v8.20.0)

---
updated-dependencies:
- dependency-name: ajv
  dependency-version: 8.20.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Jonathan Kingston <jonathanKingston@users.noreply.github.com>
Co-authored-by: Jonathan Kingston <jonathanKingston@users.noreply.github.com>
@github-actions github-actions Bot added the semver-patch Bug fix / internal — no release needed label May 22, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 22, 2026

[Beta] Generated file diff

Time updated: Fri, 22 May 2026 10:34:48 GMT

@github-actions
Copy link
Copy Markdown
Contributor

Build Branch

Branch pr-releases/jkt/auto/dependency-update-review-3dad
Commit 8676caa047
Updated May 22, 2026 at 10:34:04 AM UTC

Static preview entry points

QR codes (mobile preview)
Entry point QR code
Docs QR for docs preview
Static pages QR for static pages preview
Integration pages QR for integration pages preview

Integration commands

npm (Android / Extension):

npm i github:duckduckgo/content-scope-scripts#pr-releases/jkt/auto/dependency-update-review-3dad

Swift Package Manager (Apple):

.package(url: "https://github.com/duckduckgo/content-scope-scripts.git", branch: "pr-releases/jkt/auto/dependency-update-review-3dad")

git submodule (Windows):

git -C submodules/content-scope-scripts fetch origin pr-releases/jkt/auto/dependency-update-review-3dad
git -C submodules/content-scope-scripts checkout origin/pr-releases/jkt/auto/dependency-update-review-3dad
Pin to exact commit

npm (Android / Extension):

npm i github:duckduckgo/content-scope-scripts#8676caa0470d3ad98a81aef4b8b462eebfa88ddf

Swift Package Manager (Apple):

.package(url: "https://github.com/duckduckgo/content-scope-scripts.git", revision: "8676caa0470d3ad98a81aef4b8b462eebfa88ddf")

git submodule (Windows):

git -C submodules/content-scope-scripts fetch origin pr-releases/jkt/auto/dependency-update-review-3dad
git -C submodules/content-scope-scripts checkout 8676caa0470d3ad98a81aef4b8b462eebfa88ddf

Copy link
Copy Markdown
Contributor Author

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Web Compatibility Assessment

No web compatibility findings.

  • injected/integration-test/extension/manifest.json lines 6-12, severity: info. The added Gecko-only browser_specific_settings and data_collection_permissions metadata is confined to the integration-test extension manifest. It does not alter injected runtime behavior, content script matching, run_at, frame coverage, wrappers, shims, or DOM interaction patterns. web-ext lint --source-dir integration-test/extension --output json reports 0 errors, 0 warnings, and 0 notices.
  • injected/package.json line 60 and package-lock.json lines 10636-10676, severity: info. web-ext remains a dev-only dependency used by the fake-extension/test tooling path, not code bundled into page-injected scripts.

Security Assessment

No security findings.

  • package.json line 46 and package-lock.json lines 23 and 2461-2499, severity: info. The ajv/addons-linter updates are devDependency/tooling-only and remove stale transitive packages such as node-notifier, growly, shellwords, and uuid from the lockfile. There are no changes to captured-globals.js, message bridge checks, native messaging transports, origin validation, postMessage, runtime API overrides, or remote-config handling.

Risk Level

Low Risk: this PR changes dependency metadata, a test-only extension manifest, and lockfile entries only; it does not touch shipped injected source or security-sensitive runtime surfaces.

Recommendations

No code changes required. Keep the targeted validation in CI for this PR class: web-ext lint --source-dir integration-test/extension --output json and npm run build --workspace=injected both pass locally for this revision.

Open in Web View Automation 

Sent by Cursor Automation: Web compat and sec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver-patch Bug fix / internal — no release needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants