Skip to content

Add RMF icon contract coverage#2700

Draft
cursor[bot] wants to merge 1 commit into
mainfrom
jkt/auto/test-coverage-automation-a0c1
Draft

Add RMF icon contract coverage#2700
cursor[bot] wants to merge 1 commit into
mainfrom
jkt/auto/test-coverage-automation-a0c1

Conversation

@cursor
Copy link
Copy Markdown
Contributor

@cursor cursor Bot commented May 18, 2026

Asana Task/Github Issue: N/A

Description

Adds focused unit coverage for the New Tab RMF icon contract after recent RMF pictogram additions.

  • Risky behavior now covered: RMF icon names accepted from native data must stay in sync across the JSON schema enum, generated RMFIcon TypeScript union, mock fixtures/examples, and bundled *-96.svg assets.
  • Test files added/updated: special-pages/unit-test/rmf-icons.spec.mjs.
  • Why these tests materially reduce regression risk: missing enum/type/asset updates for a new RMF pictogram can silently break native-delivered messages or render broken icons; this test fails deterministically at unit-test time before integration/screenshot coverage is needed.

Testing Steps

  • npm run test-unit -w special-pages
  • npx prettier --check "special-pages/unit-test/rmf-icons.spec.mjs" && npx eslint "special-pages/unit-test/rmf-icons.spec.mjs"

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged
Open in Web View Automation 

Co-authored-by: Jonathan Kingston <jonathanKingston@users.noreply.github.com>
@github-actions github-actions Bot added the semver-patch Bug fix / internal — no release needed label May 18, 2026
@github-actions
Copy link
Copy Markdown
Contributor

[Beta] Generated file diff

Time updated: Mon, 18 May 2026 08:08:00 GMT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver-patch Bug fix / internal — no release needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant