Skip to content

Add support for webDetection conditionals#2687

Draft
GuiltyDolphin wants to merge 1 commit into
mainfrom
gd-webdetection-conditionals
Draft

Add support for webDetection conditionals#2687
GuiltyDolphin wants to merge 1 commit into
mainfrom
gd-webdetection-conditionals

Conversation

@GuiltyDolphin
Copy link
Copy Markdown
Member

@GuiltyDolphin GuiltyDolphin commented May 8, 2026

Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/1212311623899110/task/1213082156771927?focus=true

Description

Adds support for extended conditional logic to web detection.

Note: requires duckduckgo/privacy-configuration#5126 for type checks to pass.

Testing Steps

Unit tests.

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@github-actions github-actions Bot added the semver-patch Bug fix / internal — no release needed label May 8, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

[Beta] Generated file diff

Time updated: Fri, 08 May 2026 14:41:58 GMT

Android
    - android/adsjsContentScope.js
  • android/contentScope.js

File has changed

Apple
    - apple/contentScopeIsolated.js

File has changed

Chrome-mv3
    - chrome-mv3/inject.js

File has changed

Firefox
    - firefox/inject.js

File has changed

Integration
    - integration/contentScope.js

File has changed

Windows
    - windows/contentScope.js

File has changed

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

⚠️ Cursor review was not successful.

This PR requires a manual review and approval from a member of one of the following teams:

  • @duckduckgo/content-scope-scripts-owners
  • @duckduckgo/apple-devs
  • @duckduckgo/android-devs
  • @duckduckgo/team-windows-development
  • @duckduckgo/extension-owners
  • @duckduckgo/config-aor
  • @duckduckgo/breakage-aor
  • @duckduckgo/breakage

@GuiltyDolphin GuiltyDolphin removed the request for review from jonathanKingston May 8, 2026 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver-patch Bug fix / internal — no release needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant