Add browser UI lock overflow regression tests#2679
Draft
cursor[bot] wants to merge 3 commits into
Draft
Conversation
Co-authored-by: Jonathan Kingston <jonathanKingston@users.noreply.github.com>
Co-authored-by: Jonathan Kingston <jonathanKingston@users.noreply.github.com>
Contributor
Build Branch
Static preview entry points
QR codes (mobile preview)
Integration commandsnpm (Android / Extension): Swift Package Manager (Apple): .package(url: "https://github.com/duckduckgo/content-scope-scripts.git", branch: "pr-releases/jkt/auto/regression-test-coverage-6d36")git submodule (Windows): git -C submodules/content-scope-scripts fetch origin pr-releases/jkt/auto/regression-test-coverage-6d36
git -C submodules/content-scope-scripts checkout origin/pr-releases/jkt/auto/regression-test-coverage-6d36Pin to exact commitnpm (Android / Extension): Swift Package Manager (Apple): .package(url: "https://github.com/duckduckgo/content-scope-scripts.git", revision: "7aff1a74d421f283a42040da0686bebb035c64cc")git submodule (Windows): git -C submodules/content-scope-scripts fetch origin pr-releases/jkt/auto/regression-test-coverage-6d36
git -C submodules/content-scope-scripts checkout 7aff1a74d421f283a42040da0686bebb035c64cc |
Contributor
[Beta] Generated file diffTime updated: Mon, 04 May 2026 08:12:32 GMT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Asana Task/Github Issue: N/A
Description
Adds focused BrowserUiLock unit coverage for the recent overflow-y gating behavior:
htmlorbodyexplicitly uses a configured lockingoverflow-yvalue.injected/unit-test/browser-ui-lock.js._detectShouldLock(), plus a positive control that an explicit locking overflow still locks. A regression here could disable browser UI gestures on pages that are merely non-scrollable.Testing Steps
npm run test-unit -w injected -- --filter=BrowserUiLocknpm run build-locales -w injected && npm run lint-fixChecklist
Please tick all that apply: