Skip to content

Add browser UI lock overflow regression tests#2679

Draft
cursor[bot] wants to merge 3 commits into
mainfrom
jkt/auto/regression-test-coverage-6d36
Draft

Add browser UI lock overflow regression tests#2679
cursor[bot] wants to merge 3 commits into
mainfrom
jkt/auto/regression-test-coverage-6d36

Conversation

@cursor
Copy link
Copy Markdown
Contributor

@cursor cursor Bot commented May 4, 2026

Asana Task/Github Issue: N/A

Description

Adds focused BrowserUiLock unit coverage for the recent overflow-y gating behavior:

  • Risky behavior now covered: pages with no visible scrollbar no longer lock browser UI gestures unless html or body explicitly uses a configured locking overflow-y value.
  • Test files updated: injected/unit-test/browser-ui-lock.js.
  • Why this materially reduces regression risk: this covers the false-positive lock prevention path directly in _detectShouldLock(), plus a positive control that an explicit locking overflow still locks. A regression here could disable browser UI gestures on pages that are merely non-scrollable.

Testing Steps

  • npm run test-unit -w injected -- --filter=BrowserUiLock
  • npm run build-locales -w injected && npm run lint-fix

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged
Open in Web View Automation 

cursoragent and others added 3 commits May 4, 2026 08:06
Co-authored-by: Jonathan Kingston <jonathanKingston@users.noreply.github.com>
Co-authored-by: Jonathan Kingston <jonathanKingston@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

Build Branch

Branch pr-releases/jkt/auto/regression-test-coverage-6d36
Commit 7aff1a74d4
Updated May 4, 2026 at 8:11:42 AM UTC

Static preview entry points

QR codes (mobile preview)
Entry point QR code
Docs QR for docs preview
Static pages QR for static pages preview
Integration pages QR for integration pages preview

Integration commands

npm (Android / Extension):

npm i github:duckduckgo/content-scope-scripts#pr-releases/jkt/auto/regression-test-coverage-6d36

Swift Package Manager (Apple):

.package(url: "https://github.com/duckduckgo/content-scope-scripts.git", branch: "pr-releases/jkt/auto/regression-test-coverage-6d36")

git submodule (Windows):

git -C submodules/content-scope-scripts fetch origin pr-releases/jkt/auto/regression-test-coverage-6d36
git -C submodules/content-scope-scripts checkout origin/pr-releases/jkt/auto/regression-test-coverage-6d36
Pin to exact commit

npm (Android / Extension):

npm i github:duckduckgo/content-scope-scripts#7aff1a74d421f283a42040da0686bebb035c64cc

Swift Package Manager (Apple):

.package(url: "https://github.com/duckduckgo/content-scope-scripts.git", revision: "7aff1a74d421f283a42040da0686bebb035c64cc")

git submodule (Windows):

git -C submodules/content-scope-scripts fetch origin pr-releases/jkt/auto/regression-test-coverage-6d36
git -C submodules/content-scope-scripts checkout 7aff1a74d421f283a42040da0686bebb035c64cc

@github-actions github-actions Bot added the semver-patch Bug fix / internal — no release needed label May 4, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

[Beta] Generated file diff

Time updated: Mon, 04 May 2026 08:12:32 GMT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver-patch Bug fix / internal — no release needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant