[v1.2.0] Failed to set configuration option "allowed_directories", error: Attempted to dereference unique_ptr that is NULL!

[jivanic-demystdata]

When trying to set the allowed_directories configuration when starting a new DuckDB instance, I have the following error:

Exception in thread "main" java.sql.SQLException: Catalog Error: Failed to set configuration option "allowed_directories", error: Attempted to dereference unique_ptr that is NULL!
        at org.duckdb.DuckDBNative.duckdb_jdbc_startup(Native Method)
        at org.duckdb.DuckDBConnection.newConnection(DuckDBConnection.java:51)
        at org.duckdb.DuckDBDriver.connect(DuckDBDriver.java:41)
        at java.sql/java.sql.DriverManager.getConnection(DriverManager.java:683)
        at java.sql/java.sql.DriverManager.getConnection(DriverManager.java:191)
        at duck$_.<init>(duck.sc:14)
        at duck_sc$.script$lzyINIT1(duck.sc:29)
        at duck_sc$.script(duck.sc:29)
        at duck_sc$.main(duck.sc:33)
        at duck_sc.main(duck.sc)

To reproduce:

1. Install scala-cli
   See https://scala-cli.virtuslab.org/install
2. Create a new file named duck.sc
3. Copy/paste the following code into the duck.sc file:

//> using dep org.duckdb:duckdb_jdbc:1.2.0

import java.sql.DriverManager
import java.util.Properties

val config = new Properties()
config.put("enable_external_access", "false")
// allowed_directories value took from https://github.com/duckdb/duckdb/blob/f317a112e0c789a11987d9de6d621d8469c00fb8/test/sql/settings/allowed_directories.test#L16
config.put("allowed_directories", "['data/csv/glob']")

DriverManager.getConnection("jdbc:duckdb:", config)

4. Run the duck.sc file with the bash cmd:

scala-cli duck.sc

Notice that commenting the line config.put("allowed_directories", "['data/csv/glob']") removes the error

[jivanic-demystdata]

DuckDB v1.2.1 doesn't fix this issue

Cc @hannes

[staticlibs]

@jivanic-demystdata Hi! Will look at this shortly.

[staticlibs]

DuckDB config is typed, but JDBC is coalescing everything to strings. This worked by accident with strings and bools, but this cannot work with VARCHAR[] arrays used for new allowed_directories and allowed_paths options.

Intended typed JDBC config usage examples:

        config.put("enable_external_access", false);
        config.put("allowed_directories", List.of("path/to/dir1", "path/to/dir2"));
        config.put("http_timeout", 42);

        config.putAll(Map.ofEntries(
                entry("enable_external_access", false),
                entry("allowed_directories", List.of(
                        "path/to/dir1",
                        "path/to/dir2")),
                entry("http_timeout", 42)));

        config.putAll(ImmutableMap.builder()
                .put("enable_external_access", false)
                .put("allowed_directories", ImmutableList.builder()
                        .add("path/to/dir1")
                        .add("path/to/dir2")
                        .build())
                .put("http_timeout", 42)
                .build());

I will prepare a patch.

[staticlibs]

@jivanic-demystdata

I've submitted the fix in #159. Overall there is a long list of other minor (and not so minor) JDBC issues, if some of them are known to be more disrupting than others - please feel free to tag me directly in such ones.

[jivanic-demystdata]

@staticlibs

Overall there is a long list of other minor (and not so minor) JDBC issues, if some of them are known to be more disrupting than others

Where can I see the list? Is this just the GitHub issues?
Let me know if you need help reproducing some of these issues. I can try to replicate them in our project.

[staticlibs]

@jivanic-demystdata

Yes, just the list of GitHub issues in this repo.