Combine/Merge with xUnit.Xamarin?

[clairernovotny]

Any chance we can combine efforts here and make the PCLTesting GUI based on the xUnit stuff? xUnit does support all platforms now and it may be better to use its attributes/mechanisms than introducing another test platform.

I already have a very primitive Xamarin Forms-based runner here: https://github.com/xunit/xamarin.xunit, and it'd be great to make it better. The xUnit.Xamarin stuff already supports WP8 SL, Xam.iOS and Xam.Android.

[AArnott]

I'm in favor, yes. xunit wasn't up to par when this work was done but now
that it is I'd love to unify. Are you interested in doing this work?

Suggestion: Feel free to steal liberally from this project to build yours
up. Then send us a pull request that removes our copy and adds a dependency
on your xunit runner, perhaps?
PCLTesting makes mstest attributes work in PCL (sorta) so folks who have
a dependency on that shouldn't be broken. But once you've built up your
test runner (which I haven't looked at yet btw) I expect and would suggest
folks use xunit with your runner rather than use PCLTesting at all.

Am I on the right track here?

On Mon Jan 05 2015 at 6:13:21 AM Oren Novotny notifications@github.com
wrote:

Any chance we can combine efforts here and make the PCLTesting GUI based
on the xUnit stuff? xUnit does support all platforms now and it may be
better to use its attributes/mechanisms than introducing another test
platform.

I already have a very primitive Xamarin Forms-based runner here:
https://github.com/xunit/xamarin.xunit, and it'd be great to make it
better. The xUnit.Xamarin stuff already supports WP8 SL, Xam.iOS and
Xam.Android.

—
Reply to this email directly or view it on GitHub
#4.

[clairernovotny]

I think you're on the right track. I need to go look at your runner GUI code again and see what I can adapt. Honestly the runner UI in the xamarin.xunit stuff is very basic because up until Xam Forms 1.3, the XAML was very limiting. Fortunately Xam Forms 1.3 added a ton of things (combined with R# 9) that make writing XAML as easy as you can with Microsoft XAML -- so I think we can quickly make a more workable UI.

For your suggestion of a PR that puts a dependency on xamarin.xunit instead, I assume you mean that for the end-projects like PCLStorage/PCLCrypto, right? the xamarin.xunit project doesn't know anything about the mstest attributes without extra work. I suppose we can write a custom test discoverer that do it but that may not be worth it.

[clairernovotny]

So check this out: xunit/devices.xunit@2849170. I've pulled the filtered collection view and filtered results.

I think it does everything you do have currently. I just need @bradwilson to push a new public xunit with the Unified support then I can support that too.

Do you want me to submit a PR that switches either aarnot/PCLCrypto or dsplaisted/pclstorage over to use xUnit? What's the best place to start to validate/smoke test this against your existing code/tests?