Skip to content

Commit afcd414

Browse files
joaodinissfclaude
andcommitted
chore: enable PMD GuardLogStatement rule
Remove the GuardLogStatement exclusion and configure the rule for debug/trace levels. Also replace bare TODO comments on remaining excluded rules (PreserveStackTrace, UseTryWithResources) with actionable descriptions. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent defca08 commit afcd414

1 file changed

Lines changed: 6 additions & 1 deletion

File tree

ddk-configuration/pmd/ruleset.xml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,6 @@
7575
<exclude name="UnusedPrivateMethod"/><!-- false positives-->
7676
<exclude name="DefaultLabelNotLastInSwitch"/>
7777
<exclude name="ForLoopCanBeForeach"/>
78-
<exclude name="GuardLogStatement"/><!--TODO-->
7978
<exclude name="ImplicitFunctionalInterface"/>
8079
<exclude name="UnitTestAssertionsShouldIncludeMessage"/>
8180
<exclude name="UnitTestContainsTooManyAsserts"/><!--New after PMD 5.3 upgrade, limitation to 1 assert not sensible, would need customization, disabled for the time being-->
@@ -88,6 +87,12 @@
8887
<exclude name="UnusedLocalVariable"/><!--Checkstyle-->
8988
<exclude name="JUnit5TestShouldBePackagePrivate"/>
9089
</rule>
90+
<rule ref="category/java/bestpractices.xml/GuardLogStatement">
91+
<properties>
92+
<property name="logLevels" value="trace,debug" />
93+
<property name="guardsMethods" value="isTraceEnabled,isDebugEnabled" />
94+
</properties>
95+
</rule>
9196
<rule ref="category/java/bestpractices.xml/UnusedFormalParameter">
9297
<properties>
9398
<property name="checkAll" value="true" />

0 commit comments

Comments
 (0)