Skip to content

Commit 607b20f

Browse files
joaodinissfclaude
andcommitted
fix: add SLF4J NOP binding to target, clean up stale imports
Add slf4j.nop 1.7.36 from Eclipse Orbit aggregation 4.39.0 to the DDK target platform, providing the SLF4J 1.7.x StaticLoggerBinder that Xtext's transitive slf4j.api bundle looks for at runtime. This silences the "Failed to load class org.slf4j.impl.StaticLoggerBinder" warning. Remove unused Import-Package: org.slf4j from three test bundle manifests where no source file references org.slf4j: - com.avaloq.tools.ddk.check.ui.test - com.avaloq.tools.ddk.xtext.test - com.avaloq.tools.ddk.xtext.test.core Retains org.slf4j in com.avaloq.tools.ddk.test.ui — its SwtBot wrapper classes directly use org.slf4j.Logger. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 06de656 commit 607b20f

4 files changed

Lines changed: 5 additions & 6 deletions

File tree

com.avaloq.tools.ddk.check.ui.test/META-INF/MANIFEST.MF

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,7 @@ Require-Bundle: com.avaloq.tools.ddk.check.ui,
2929
Export-Package: com.avaloq.tools.ddk.check.ui.test,
3030
com.avaloq.tools.ddk.check.ui.test.util,
3131
com.avaloq.tools.ddk.check
32-
Import-Package: org.slf4j,
33-
org.hamcrest.core,
32+
Import-Package: org.hamcrest.core,
3433
org.junit.runner;version="4.5.0",
3534
org.junit.runner.manipulation;version="4.5.0",
3635
org.junit.runner.notification;version="4.5.0",

com.avaloq.tools.ddk.xtext.test.core/META-INF/MANIFEST.MF

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ Require-Bundle: com.avaloq.tools.ddk.xtext,
2626
org.eclipse.emf.common,
2727
com.avaloq.tools.ddk,
2828
junit-jupiter-api
29-
Import-Package: org.slf4j, org.apache.logging.log4j
29+
Import-Package: org.apache.logging.log4j
3030
Export-Package: com.avaloq.tools.ddk.xtext.test,
3131
com.avaloq.tools.ddk.xtext.test.contentassist,
3232
com.avaloq.tools.ddk.xtext.test.conversion,

com.avaloq.tools.ddk.xtext.test/META-INF/MANIFEST.MF

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,7 @@ Import-Package: com.avaloq.tools.ddk.check.runtime.test.core,
4646
com.avaloq.tools.ddk.xtext.test.export,
4747
com.avaloq.tools.ddk.xtext.test.format,
4848
com.avaloq.tools.ddk.xtext.ui.test,
49-
org.apache.logging.log4j,
50-
org.slf4j
49+
org.apache.logging.log4j
5150
Export-Package: com.avaloq.tools.ddk.xtext,
5251
com.avaloq.tools.ddk.xtext.formatter,
5352
com.avaloq.tools.ddk.xtext.formatter.services,

ddk-target/ddk.target

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,8 @@
5757
<unit id="org.apache.commons.lang3" version="3.20.0"/>
5858
<unit id="org.apache.logging.log4j.core" version="2.25.3"/>
5959
<unit id="org.apache.logging.log4j.api" version="2.25.3"/>
60-
<unit id="org.apache.log4j" version="1.2.26"/> <!--use reload4j 1.2.26 for org.eclipse.xtext dependencies to log4j-->
60+
<unit id="org.apache.log4j" version="1.2.26"/> <!--use reload4j 1.2.26 for org.eclipse.xtext dependencies to log4j-->
61+
<unit id="slf4j.nop" version="1.7.36"/>
6162
</location>
6263
<location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit">
6364
<repository location="https://download.eclipse.org/tools/orbit/simrel/maven-osgi/release/4.39.0"/>

0 commit comments

Comments
 (0)