Skip to content

Commit 1f986ca

Browse files
joaodinissfclaude
andcommitted
fix: ensure all Bug* tests are discoverable and standardize test suites
- Rename BugAig1314, BugDsl27, BugAig1084 to *Test suffix so they match JUnit 5 default class name pattern and Tycho's **/*Test.java convention - Add missing expression package to GeneratorTestSuite @SelectPackages - Add @IncludeClassNamePatterns(".*Test.*") to all suites for consistency Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 9fed608 commit 1f986ca

10 files changed

Lines changed: 20 additions & 6 deletions

File tree

com.avaloq.tools.ddk.check.core.test/src/com/avaloq/tools/ddk/check/core/test/BugAig1314.java renamed to com.avaloq.tools.ddk.check.core.test/src/com/avaloq/tools/ddk/check/core/test/BugAig1314Test.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242
@ExtendWith(InjectionExtension.class)
4343
@InjectWith(CheckInjectorProvider.class)
4444
@SuppressWarnings("nls")
45-
class BugAig1314 {
45+
class BugAig1314Test {
4646

4747
/** Constructor of super class is protected... */
4848
private static class TestScope extends CatalogFromExtensionPointScope {
@@ -74,7 +74,7 @@ private ModelLocation createModelLocation(final URL url) {
7474
return new ModelLocation(url, TEST_CATALOG_FILE + TEST_CATALOG_EXTENSION) {
7575
@Override
7676
public InputStream getCatalogStream() {
77-
return BugAig1314.class.getResourceAsStream(TEST_CATALOG_FILE);
77+
return BugAig1314Test.class.getResourceAsStream(TEST_CATALOG_FILE);
7878
}
7979
};
8080
}

com.avaloq.tools.ddk.check.core.test/src/com/avaloq/tools/ddk/check/core/test/BugDsl27.java renamed to com.avaloq.tools.ddk.check.core.test/src/com/avaloq/tools/ddk/check/core/test/BugDsl27Test.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,14 +27,14 @@
2727
@InjectWith(CheckInjectorProvider.class)
2828
@ExtendWith(InjectionExtension.class)
2929
@SuppressWarnings("nls")
30-
class BugDsl27 extends AbstractCheckGenerationTestCase {
30+
class BugDsl27Test extends AbstractCheckGenerationTestCase {
3131

3232
/**
3333
* Tests that our test source compiles fine.
3434
*/
3535
@Test
3636
void testGeneratedCodeHasNoErrors() {
37-
try (InputStream sourceStream = BugDsl27.class.getResourceAsStream("bugdsl27/BugDsl27")) {
37+
try (InputStream sourceStream = BugDsl27Test.class.getResourceAsStream("bugdsl27/BugDsl27")) {
3838
generateAndCompile(sourceStream);
3939
} catch (IOException exception) {
4040
LOGGER.info("Failed to close the test file");

com.avaloq.tools.ddk.check.core.test/src/com/avaloq/tools/ddk/check/test/core/CheckCoreTestSuite.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
*******************************************************************************/
1111
package com.avaloq.tools.ddk.check.test.core;
1212

13+
import org.junit.platform.suite.api.IncludeClassNamePatterns;
1314
import org.junit.platform.suite.api.SelectPackages;
1415
import org.junit.platform.suite.api.Suite;
1516

@@ -22,6 +23,7 @@
2223
@SelectPackages({
2324
"com.avaloq.tools.ddk.check.core.test"
2425
})
26+
@IncludeClassNamePatterns(".*Test.*")
2527
class CheckCoreTestSuite {
2628

2729
}

com.avaloq.tools.ddk.check.test.runtime.tests/src/com/avaloq/tools/ddk/check/test/runtime/tests/CheckExecutionEnvironmentTestSuite.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
*******************************************************************************/
1111
package com.avaloq.tools.ddk.check.test.runtime.tests;
1212

13+
import org.junit.platform.suite.api.IncludeClassNamePatterns;
1314
import org.junit.platform.suite.api.SelectPackages;
1415
import org.junit.platform.suite.api.Suite;
1516

@@ -22,6 +23,7 @@
2223
@SelectPackages({
2324
"com.avaloq.tools.ddk.check.test.runtime"
2425
})
26+
@IncludeClassNamePatterns(".*Test.*")
2527
class CheckExecutionEnvironmentTestSuite {
2628

2729
}

com.avaloq.tools.ddk.check.test.runtime.tests/src/com/avaloq/tools/ddk/check/test/runtime/tests/CheckLibraryChecksTestSuite.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111

1212
package com.avaloq.tools.ddk.check.test.runtime.tests;
1313

14+
import org.junit.platform.suite.api.IncludeClassNamePatterns;
1415
import org.junit.platform.suite.api.SelectPackages;
1516
import org.junit.platform.suite.api.Suite;
1617

@@ -23,6 +24,7 @@
2324
@SelectPackages({
2425
"com.avaloq.tools.ddk.check.test.runtime.label"
2526
})
27+
@IncludeClassNamePatterns(".*Test.*")
2628
class CheckLibraryChecksTestSuite {
2729

2830
}

com.avaloq.tools.ddk.check.ui.test/src/com/avaloq/tools/ddk/check/ui/test/CheckUiTestSuite.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
*******************************************************************************/
1111
package com.avaloq.tools.ddk.check.ui.test;
1212

13+
import org.junit.platform.suite.api.IncludeClassNamePatterns;
1314
import org.junit.platform.suite.api.SelectPackages;
1415
import org.junit.platform.suite.api.Suite;
1516

@@ -26,5 +27,6 @@
2627
"com.avaloq.tools.ddk.check.ui.test.quickfix"
2728
})
2829
// @Format-On
30+
@IncludeClassNamePatterns(".*Test.*")
2931
class CheckUiTestSuite {
3032
}

com.avaloq.tools.ddk.test.ui.test/src/com/avaloq/tools/ddk/test/ui/test/AllTests.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
*******************************************************************************/
1111
package com.avaloq.tools.ddk.test.ui.test;
1212

13+
import org.junit.platform.suite.api.IncludeClassNamePatterns;
1314
import org.junit.platform.suite.api.SelectPackages;
1415
import org.junit.platform.suite.api.Suite;
1516

@@ -22,5 +23,6 @@
2223
@SelectPackages({
2324
"com.avaloq.tools.ddk.test.ui.test.swtbot"
2425
})
26+
@IncludeClassNamePatterns(".*Test.*")
2527
class AllTests {
2628
}

com.avaloq.tools.ddk.xtext.generator.test/src/com/avaloq/tools/ddk/xtext/generator/test/generator/GeneratorTestSuite.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
*******************************************************************************/
1111
package com.avaloq.tools.ddk.xtext.generator.test.generator;
1212

13+
import org.junit.platform.suite.api.IncludeClassNamePatterns;
1314
import org.junit.platform.suite.api.SelectPackages;
1415
import org.junit.platform.suite.api.Suite;
1516

@@ -20,8 +21,9 @@
2021
*/
2122
@Suite
2223
@SelectPackages({
24+
"com.avaloq.tools.ddk.xtext.generator.expression",
2325
"com.avaloq.tools.ddk.xtext.generator.test.util"
2426
})
25-
27+
@IncludeClassNamePatterns(".*Test.*")
2628
class GeneratorTestSuite {
2729
}

com.avaloq.tools.ddk.xtext.test/src/com/avaloq/tools/ddk/xtext/resource/BugAig1084.java renamed to com.avaloq.tools.ddk.xtext.test/src/com/avaloq/tools/ddk/xtext/resource/BugAig1084Test.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
import com.google.common.collect.Lists;
2525

2626

27-
class BugAig1084 {
27+
class BugAig1084Test {
2828

2929
/**
3030
* Test that recursive calls to {@link ResourceDescription2#getLookUp()} by {@link ResourceDescription2#computeExportedObjects()} do not cause

com.avaloq.tools.ddk.xtext.ui.test/src/com/avaloq/tools/ddk/xtext/ui/test/XtextUiTestSuite.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111

1212
package com.avaloq.tools.ddk.xtext.ui.test;
1313

14+
import org.junit.platform.suite.api.IncludeClassNamePatterns;
1415
import org.junit.platform.suite.api.SelectPackages;
1516
import org.junit.platform.suite.api.Suite;
1617

@@ -25,5 +26,6 @@
2526
"com.avaloq.tools.ddk.xtext.ui.templates"
2627
// @Format-On
2728
})
29+
@IncludeClassNamePatterns(".*Test.*")
2830
class XtextUiTestSuite {
2931
}

0 commit comments

Comments
 (0)