Skip to content

IOSuccess / IOFailure and match-case #2355

@ixemad

Description

@ixemad

I don't really see the point of IOSuccess and IOFailure. From one hand, IOResult.from_value(1) == IOSuccess.from_value(1). Actually ,IOSuccess.from_value(1) == IOFailure.from_value(1).
I would also expect some benefit when using it in a match-case. Something like:

value = IOSuccess.from_value(1)
match value:
    case IOSuccess(v): assert(v == 1)
    case _: pass

However, the "correct" code is

value = IOSuccess.from_value(1)
match value:
    case IOResult(Success(v)): assert(v == 1)
    case _: pass

Therefore, IOSuccess and IOFailure as aliases are quite confusing. Don't you think?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions