Failed to upload artifact 404 Not found

[mschwei]

I'm getting the following error using the latest version.

level=error msg="execution failed: failed to upload the files: failed to upload package.zip artifact: POST enterpriseinstance/api/v3/upload/repos/org/reponame/releases/98009/assets?name=package.zip: 404 Not Found []"

I suspect that tht issue is with discussion_category_name, similar/or related to #89 due to a change at he GH API. #89 also has a linked PR of a merge that seems to address that.

Could you please check and povide a new version?

[mschwei]

Related to this, I have a GH Enterprise where discussions do not see to be enabled. So maybe there is no default value for the cateogory name and would need to specified now?

[donny-dont]

@mschwei can you try again with the latest version of the plugin?

[codyrancher]

@donny-dont I'm not sure if this is related or not but I'm also getting a 404 even though the resource clearly exists. Let me know if I should open a separate issue.

Found release 68896408 for tag plugin-aa-a

time="2022-06-07T23:58:25Z" level=error msg="execution failed: failed to create the release: failed to create or edit a release: failed to update release: PATCH https://api.github.com/repos/rancher/opni-ui/releases/68896408: 404 Not Found []"

And I do believe I have the latest with this as the step in my drone config:

name: plugin-upload-zip
    image: plugins/github-release
    pull: always

[donny-dont]

@codyrancher are you using GitHub or GitHub Enterprise?

[codyrancher]

Honestly I'm not sure how to verify. I believe we're using GitHub Enterprise Cloud.

[chriskuehl]

The issue for me seems to be the /v3/ in the URL here:

drone-github-release/plugin/impl.go

Line 177 in ccfc07d

relUploadURL, _ := url.Parse("./api/v3/upload/")

At least on my GitHub Enterprise instance, there is not supposed to be a /v3/ in the upload_url for a release:

$ curl 'https://github.myenterprise/api/v3/repos/chris-kuehl/myrepo/releases/14764' -H 'Authorization: Bearer XXX'
{
  "url": "https://github.myenterprise/api/v3/repos/chris-kuehl/myrepo/releases/14764",
  "assets_url": "https://github.myenterprise/api/v3/repos/chris-kuehl/myrepo/releases/14764/assets",
  "upload_url": "https://github.myenterprise/api/uploads/repos/chris-kuehl/myrepo/releases/14764/assets{?name,label}",
[...]

I was able to set PLUGIN_BASE_URL=https://github.myenterprise/api/v3/ and PLUGIN_UPLOAD_URL=https://github.myenterprise/api/uploads/ which resolved the 404 for me, although I do get a warning in my logs:

Both base_url and upload_url are deprecated. Please remove them from your config!