Application's borders aren't black

[adambriny]

If you're reporting an UI issue, make sure you take a screenshot that shows the actual bug.

There are several parts which aren't black.

Some system info:

• Windows 10 1709
• Git: 2.19.0.windows.1

[K1Z4]

Looks to be related to this line where the background isn't set for Windows for some reason.

https://github.com/git/git/blob/3cb8921f74354a3a4aeaa932869acb7e6aabe630/gitk-git/gitk#L11767

God help you if you wanted to submit a PR to the git repo though, looks like a nightmare 🙄

[guoliang]

I'm here for the same reason. Looks like no one has tried to fix it yet :(

[jussi-muhonen-nexstim]

I'd upvote this issue...

[tcladin]

Looks to be related to this line where the background isn't set for Windows for some reason.

https://github.com/git/git/blob/3cb8921f74354a3a4aeaa932869acb7e6aabe630/gitk-git/gitk#L11767

God help you if you wanted to submit a PR to the git repo though, looks like a nightmare 🙄

Little better dark for w32

in C:\Program Files\Git\mingw64\bin\gitk

# This sets the background color and the color scheme for the whole UI.
# For some reason, tk_setPalette chooses a nasty dark red for selectColor
# if we don't specify one ourselves, which makes the checkbuttons and
# radiobuttons look bad.  This chooses white for selectColor if the
# background color is light, or black if it is dark.

# before modification by tcl 2025-04-20
# proc setui {c} {
    # if {[tk windowingsystem] eq "win32"} { return }
    # set bg [winfo rgb . $c]
    # set selc black
    # if {[lindex $bg 0] + 1.5 * [lindex $bg 1] + 0.5 * [lindex $bg 2] > 100000} {
        # set selc white
    # }
    # tk_setPalette background $c selectColor $selc
# }

# modification by tcl 2025-04-20
proc setui {c} {
    if {[tk windowingsystem] eq "win32"} {
        set bg [winfo rgb . $c]
        set selc black
        tk_setPalette background $c selectColor $selc
        return
    }
    set bg [winfo rgb . $c]
    set selc black
    if {[lindex $bg 0] + 1.5 * [lindex $bg 1] + 0.5 * [lindex $bg 2] > 100000} {
        set selc white
    }
    tk_setPalette background $c selectColor $selc
}