Fix DefaultVerificationExcludePatterns to use ** for recursive matching#54390
Open
NikolaMilosavljevic wants to merge 4 commits into
Open
Fix DefaultVerificationExcludePatterns to use ** for recursive matching#54390NikolaMilosavljevic wants to merge 4 commits into
NikolaMilosavljevic wants to merge 4 commits into
Conversation
The default exclude patterns used single * (e.g. **/obj/*) which only matches files directly inside obj/ or bin/ directories. Changed to ** (e.g. **/obj/**) to recursively match all nested paths like obj/Debug/net10.0/AssemblyInfo.cs. Fixes dotnet#54274 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes TemplateVerifier’s default verification exclude patterns so obj/ and bin/ are excluded recursively (matching nested build outputs), addressing #54274 and reducing snapshot noise for buildable templates.
Changes:
- Updated the default exclude globs from
**/obj/*/**/bin/*to**/obj/**/**/bin/**(and the backslash variants) for recursive matching. - Added a unit test to ensure nested
obj/andbin/files are excluded by default.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/TemplateEngine/Tools/Microsoft.TemplateEngine.Authoring.TemplateVerifier/VerificationEngine.cs | Broadens default exclude globs to recursively filter obj/ and bin/ contents. |
| test/TemplateEngine/Microsoft.TemplateEngine.Authoring.TemplateVerifier.UnitTests/VerificationEngineTests.cs | Adds coverage for nested obj/bin exclusion behavior via a new unit test. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/sdk#54274
The
DefaultVerificationExcludePatternsinVerificationEngine.csused single*globs (e.g.**/obj/*) which only match files directly insideobj/orbin/— not nested paths likeobj/Debug/net10.0/AssemblyInfo.cs. Changed to**(e.g.**/obj/**) for recursive matching.Changes
src/TemplateEngine/Tools/Microsoft.TemplateEngine.Authoring.TemplateVerifier/VerificationEngine.cs— Changed 4 default exclude patterns from*to**in the trailing segmenttest/TemplateEngine/Microsoft.TemplateEngine.Authoring.TemplateVerifier.UnitTests/VerificationEngineTests.cs— AddedDefaultExcludePatternsFilterNestedObjAndBinFilestest verifying nestedobj/binfiles are properly excludedBuild & Test