Merge branch 'main' into fix-17107-allowmultiple-inherited-csharp

Author: edgarfgp

.config/service-branch-merge.json

@@ -16,6 +16,18 @@
         "release/dev18.0": {
             "MergeToBranch": "main",
             "ExtraSwitches": "-QuietComments"
+        },
+        "main": {
+            "MergeToBranch": "feature/net11-scouting",
+            "ExtraSwitches": "-QuietComments",
+            "ResetToTargetPaths": [
+                "global.json",
+                "eng/Version.Details.xml",
+                "eng/Version.Details.props",
+                "eng/Versions.props",
+                "eng/common/**",
+                "eng/TargetFrameworks.props"
+            ]
         }
     }
 }

.github/agents/fsharp-release-announcement.md

@@ -0,0 +1,169 @@
+---
+name: F# Release Announcement
+description: Craft F# release announcements for .NET preview/release milestones by tracing SDK→VMR→dotnet/fsharp commit ranges, analyzing release notes, PRs, and issues, then producing a markdown article.
+---
+
+# 0. Resolve SDK branch names
+
+User provides only a target release name (e.g., ".NET 11 Preview 2"). Derive everything else.
+
+```bash
+# List all release branches in dotnet/sdk
+gh api repos/dotnet/sdk/branches --paginate -q '.[].name' | grep '^release/' | sort -V
+```
+
+Branch naming pattern: `release/<major>.0.<band>xx-preview<N>` or `release/<major>.0.<band>xx`
+
+From the listing, identify:
+1. **Target branch**: match release name to branch (e.g., ".NET 11 Preview 2" → `release/11.0.1xx-preview2`)
+2. **Previous branch**: prior preview or prior milestone (e.g., preview1 for preview2, or last stable for preview1)
+3. **Parallel stable branch**: highest `<major-1>.0.Xxx` branch (for exclusivity check)
+
+# 1. Fetch previous announcement — DO NOT REPEAT
+
+```
+gh api repos/dotnet/core/contents/release-notes -q '.[].name'
+```
+
+Navigate to latest published `fsharp.md` under `release-notes/<major>/preview/*/`. Fetch it. Every item in it is excluded from output.
+
+# 2. Resolve F# commit range
+
+**CRITICAL**: Use SDK, not VMR branch. VMR branch may have newer F# than what SDK locked in.
+
+### Get F# end commit (target release)
+
+```
+# 1. SDK → VMR hash (find the Dependency for Microsoft.FSharp.Compiler, extract its Sha)
+gh api repos/dotnet/sdk/contents/eng/Version.Details.xml?ref=release/11.0.1xx-preview2 | jq -r '.content' | base64 -d | grep -A2 'Microsoft.FSharp.Compiler' | grep Sha | sed 's/.*>\([a-f0-9]*\)<.*/\1/'
+# Result: VMR_HASH
+
+# 2. VMR → F# hash
+gh api repos/dotnet/dotnet/contents/src/source-manifest.json?ref=VMR_HASH | jq -r '.content' | base64 -d | jq -r '.repositories[] | select(.path=="fsharp") | .commitSha'
+# Result: FSHARP_END
+```
+
+### Get F# start commit (previous release)
+
+Repeat above with previous SDK branch (e.g., `release/11.0.1xx-preview1`).
+Result: `FSHARP_START`
+
+### Cross-check with parallel SDK branch
+
+Repeat for `release/10.0.3xx` (or current stable band). Compare F# hash. Determine if features are shared or exclusive.
+
+# 3. Diff release notes
+
+```bash
+git diff FSHARP_START..FSHARP_END -- docs/release-notes/ | grep '^+' | grep -v '^+++'
+```
+
+Source files:
+- `docs/release-notes/.FSharp.Compiler.Service/*.md`
+- `docs/release-notes/.FSharp.Core/*.md`
+- `docs/release-notes/.Language/*.md`
+- `docs/release-notes/.VisualStudio/*.md`
+
+### EXCLUDE
+
+- Already in previous announcement
+- CI, infra, test-only, repo maintenance, dependency updates, localization
+- FCS-internal API (unless enables user scenario)
+- xUnit migration, build scripts, baseline updates
+
+# 4. Investigate each entry via sub-agents
+
+For each user-facing release note entry, spawn a sub-agent (explore or general-purpose) to investigate it independently. Each sub-agent writes its findings to a temp file.
+
+```
+For each entry with PR #NUMBER:
+
+  Launch sub-agent with prompt:
+  """
+  Investigate dotnet/fsharp PR #NUMBER.
+  1. Get PR author, title, description, linked issues
+  2. Get files changed — classify as: feature / bugfix / test-only / infra
+  3. If feature or significant bugfix:
+     - Find test files: git diff-tree --no-commit-id -r <MERGE_SHA> --name-only | grep -i test
+     - Extract the most illustrative code sample from the tests (real F# code, not test harness)
+     - Note benchmark data if PR description has any
+  4. If author is NOT T-Gro, Copilot, or abonie → mark as community contributor
+  5. Write findings to /tmp/release-notes/pr-NUMBER.md in this format:
+
+  ## PR #NUMBER: <title>
+  - Author: <login> (community: yes/no)
+  - Type: feature | bugfix | api | perf | infra
+  - One-line summary: <what changed for users>
+  - Issue(s): #X, #Y
+  - Code sample (if feature/api):
+  ```fsharp
+  <code from tests>
+  ```
+  - Benchmark (if perf):
+  <table or numbers from PR>
+  """
+```
+
+Run sub-agents in parallel (up to 5). Wait for all to complete. Read all `/tmp/release-notes/pr-*.md` files to assemble the full picture.
+
+Skip entries where sub-agent classified as `infra` or `test-only`.
+
+# 5. Write the article
+
+## Attribution
+
+- Community contributors: `Thanks to [**user**](https://github.com/user)` with link
+- NEVER mention: T-Gro, Copilot, abonie (internal)
+- Credit community even if their PR was superseded (e.g., "Inspired by [**user**]'s work in #XXXX")
+
+## Structure
+
+```markdown
+# F# in .NET XX Preview Y - Release Notes
+
+Here's a summary of what's new in F# in this Preview Y release:
+
+- [Highlight 1](#anchor)
+- [Highlight 2](#anchor)
+- [Category 1](#anchor)
+- [Category 2](#anchor)
+- [Bug fixes](#bug-fixes-and-other-improvements)
+
+## Highlight 1              ← 1-3 sections, CODE SAMPLES from tests, minimal prose
+## Highlight 2
+## Category: Query fixes    ← bullet list with issue links, no code
+## Category: IDE fixes      ← bullet list
+## Bug fixes                ← flat bullet list, prefixed by area (Nullness:, Scripts:, etc.)
+
+F# updates:
+- [F# release notes](https://fsharp.github.io/fsharp-compiler-docs/release-notes/About.html)
+- [dotnet/fsharp repository](https://github.com/dotnet/fsharp)
+```
+
+## Highlight selection (pick 1-3)
+
+Rank by: language feature > new API > perf win with numbers > significant bug fix area
+Each MUST have code sample extracted from PR tests. No invented examples.
+
+## Style
+
+- One-sentence intro max, then code block or table
+- No fluff, no "we are excited", no "this release brings"
+- Bold key terms in bullet lists
+- Link every issue and PR number
+
+# SDK branch naming
+
+| Release | Branch |
+|---|---|
+| .NET 11 Preview N | `release/11.0.1xx-previewN` |
+| .NET 10.0.X00 | `release/10.0.Xxx` |
+
+# Key files
+
+| Repo | Path | Contains |
+|---|---|---|
+| dotnet/sdk | `eng/Version.Details.xml` | VMR commit SHA |
+| dotnet/dotnet | `src/source-manifest.json` | F# commit SHA |
+| dotnet/fsharp | `docs/release-notes/` | Per-version changelogs |
+| dotnet/core | `release-notes/` | Published announcements |

.github/skills/pr-build-status/scripts/Get-PrBuildIds.ps1

@@ -19,7 +19,12 @@
     ./Get-PrBuildIds.ps1 -PrNumber 33251 -Repo "dotnet/fsharp"
 
 .OUTPUTS
-    Array of objects with Pipeline, BuildId, State, and Link properties.
+    Array of objects with Pipeline, BuildId, State, Detail, and Link properties.
+    The State represents the worst-case state across all jobs in the build:
+    - FAILURE if any job failed
+    - IN_PROGRESS if any job is still running or queued
+    - SUCCESS if all jobs completed successfully
+    The Detail field shows the count of jobs in each state.
 #>
 
 [CmdletBinding()]
@@ -60,6 +65,30 @@ $builds = $checks | Where-Object { $_.link -match "dev\.azure\.com" } | ForEach-
         State    = $_.state
         Link     = $_.link
     }
-} | Sort-Object -Property Pipeline, BuildId -Unique
+} | Group-Object BuildId | ForEach-Object {
+    $jobs = $_.Group
+    $states = $jobs | Select-Object -ExpandProperty State -Unique
+    
+    # Determine overall state (worst case wins)
+    $overall = if ($states -contains "FAILURE") { 
+        "FAILURE" 
+    }
+    elseif ($states -contains "IN_PROGRESS" -or $states -contains "QUEUED") { 
+        "IN_PROGRESS" 
+    }
+    else { 
+        "SUCCESS" 
+    }
+    
+    $first = $jobs | Select-Object -First 1
+    
+    [PSCustomObject]@{
+        Pipeline = $first.Pipeline
+        BuildId  = $first.BuildId
+        State    = $overall
+        Detail   = ($jobs | Group-Object State | ForEach-Object { "$($_.Count) $($_.Name)" }) -join ", "
+        Link     = ($first.Link -replace "\&view=.*", "")
+    }
+}
 
 $builds

VisualFSharp.sln

@@ -1,15 +1,19 @@
 
 Microsoft Visual Studio Solution File, Format Version 12.00
-# Visual Studio Version 17
-VisualStudioVersion = 17.1.32113.165
+# Visual Studio Version 18
+VisualStudioVersion = 18.3.11210.18 main
 MinimumVisualStudioVersion = 10.0.40219.1
 Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Tests", "Tests", "{CFE3259A-2D30-4EB0-80D5-E8B5F3D01449}"
 EndProject
 Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "VisualFSharp.UnitTests Support", "VisualFSharp.UnitTests Support", "{3F044931-FB83-4433-B934-AE66AB27B278}"
 EndProject
 Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "VisualFSharp", "VisualFSharp", "{4C7B48D7-19AF-4AE7-9D1D-3BB289D5480D}"
 	ProjectSection(SolutionItems) = preProject
+		vsintegration\Directory.Build.props = vsintegration\Directory.Build.props
+		vsintegration\Directory.Build.targets = vsintegration\Directory.Build.targets
 		vsintegration\readme.md = vsintegration\readme.md
+		vsintegration\Templates.Directory.Build.props = vsintegration\Templates.Directory.Build.props
+		vsintegration\Templates.Directory.Build.targets = vsintegration\Templates.Directory.Build.targets
 	EndProjectSection
 EndProject
 Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Compiler", "Compiler", "{3881429D-A97A-49EB-B7AE-A82BA5FE9C77}"

docs/release-notes/.FSharp.Compiler.Service/10.0.300.md

@@ -1,5 +1,6 @@
 ### Fixed
 
+* Fix strong name signature size to align with Roslyn for public signing ([Issue #17451](https://github.com/dotnet/fsharp/issues/17451), [PR #19242](https://github.com/dotnet/fsharp/pull/19242))
 * Nullness: Fix UoM ToString returning `string | null` for value types. ([Issue #17539](https://github.com/dotnet/fsharp/issues/17539), [PR #19262](https://github.com/dotnet/fsharp/pull/19262))
 * Nullness: Fix pipe operator nullness warning location to point at nullable argument. ([Issue #18013](https://github.com/dotnet/fsharp/issues/18013), [PR #19262](https://github.com/dotnet/fsharp/pull/19262))
 * Nullness: Fix false positive warning when passing non-null AllowNullLiteral constructor result. ([Issue #18021](https://github.com/dotnet/fsharp/issues/18021), [PR #19262](https://github.com/dotnet/fsharp/pull/19262))
@@ -29,9 +30,13 @@
 ### Added
 * FSharpType: add ImportILType ([PR #19300](https://github.com/dotnet/fsharp/pull/19300))
 * Type checker: recover on argument/overload checking ([PR #19314](https://github.com/dotnet/fsharp/pull/19314))
+* FSharpType: add more predefined type checks ([PR #19325](https://github.com/dotnet/fsharp/pull/19325))
+* Introduced a separate `NotifyRelatedSymbolUse` sink and `[<Flags>] RelatedSymbolUseKind` enum for related symbol lookups (union case testers, copy-and-update record types). `GetUsesOfSymbolInFile` and `GetSemanticClassification` accept an optional `relatedSymbolKinds` parameter to opt in. ([PR #19361](https://github.com/dotnet/fsharp/pull/19361))
 
 * Support `#exit;;` as alias to `#quit;;` in F# Interactive. ([PR #19329](https://github.com/dotnet/fsharp/pull/19329))
 
+* FCS: capture additional types during analysis ([PR #19305](https://github.com/dotnet/fsharp/pull/19305))
+
 ### Changed
 
 * Centralized product TFM (Target Framework Moniker) into MSBuild props file `eng/TargetFrameworks.props`. Changing the target framework now only requires editing one file, and it integrates with MSBuild's `--getProperty` for scripts.

docs/release-notes/.FSharp.Compiler.Service/11.0.100.md

@@ -0,0 +1,15 @@
+### Fixed
+
+* Fix codegen to produce IL passing ILVerify: specialized stelem/ldelem for primitives, callvirt→call on value types, castclass at interface join points, filter→catch inside finally handlers, witness field alignment in state machine structs. ([PR #19372](https://github.com/dotnet/fsharp/pull/19372))
+* Fix outref parameter compiled as byref. (Issue [#13468](https://github.com/dotnet/fsharp/issues/13468), [PR #19340](https://github.com/dotnet/fsharp/pull/19340))
+* Fix static abstract interface members with byref params. (Issue [#18135](https://github.com/dotnet/fsharp/issues/18135), [PR #19340](https://github.com/dotnet/fsharp/pull/19340))
+* Fix object expressions in struct types no longer generate invalid IL with byref fields. (Issue [#19068](https://github.com/dotnet/fsharp/issues/19068), [PR #19339](https://github.com/dotnet/fsharp/pull/19339))
+* Avoid duplicate parameter names in closure constructors. (Issue [#17692](https://github.com/dotnet/fsharp/issues/17692), [PR #19339](https://github.com/dotnet/fsharp/pull/19339))
+* Improve let-rec codegen: reorder bindings to allocate lambda closures before non-lambda values that reference them. ([PR #19339](https://github.com/dotnet/fsharp/pull/19339))
+* Fix `YieldFromFinal`/`ReturnFromFinal` being incorrectly called in non-tail positions (`for`, `use`, `use!`, `try/with` handler). ([Issue #19402](https://github.com/dotnet/fsharp/issues/19402), [PR #19403](https://github.com/dotnet/fsharp/pull/19403))
+* Fixed how the source ranges of warn directives are reported (as trivia) in the parser output (by not reporting leading spaces). ([Issue #19405](https://github.com/dotnet/fsharp/issues/19405), [PR #19408]((https://github.com/dotnet/fsharp/pull/19408)))
+
+### Added
+
+* Added warning FS3884 when a function or delegate value is used as an interpolated string argument. ([PR #19289](https://github.com/dotnet/fsharp/pull/19289))
+* Add `#version;;` directive to F# Interactive to display version and environment information. ([Issue #13307](https://github.com/dotnet/fsharp/issues/13307), [PR #19332](https://github.com/dotnet/fsharp/pull/19332))

docs/release-notes/.FSharp.Core/10.0.300.md

@@ -1,11 +1,14 @@
 ### Fixed
 
+* Optimize Set.intersect performance symmetry and preserve identity from the first set argument. ([PR #19291](https://github.com/dotnet/fsharp/pull/19291)) (Fixes #19139)
 * Fix anonymous record field ordering in LINQ expression conversion to produce consistent expression trees regardless of field declaration order. ([Issue #11131](https://github.com/dotnet/fsharp/issues/11131), [Issue #15648](https://github.com/dotnet/fsharp/issues/15648))
 * Fix array indexing in LINQ expressions to generate proper array index expressions instead of GetArray method calls, enabling LINQ providers like Azure Cosmos DB to translate array access. ([Issue #16918](https://github.com/dotnet/fsharp/issues/16918))
 * Fix tuple join conditions and groupBy operations to properly compare tuple keys using structural equality. AnonymousObject types now implement Equals and GetHashCode, enabling inline tuple joins like `join b on ((a.Id1, a.Id2) = (b.Id1, b.Id2))` to work correctly. ([Issue #7885](https://github.com/dotnet/fsharp/issues/7885), [Issue #47](https://github.com/dotnet/fsharp/issues/47))
 * Fix tuple/multi-value projections in queries to use Queryable.Select instead of Enumerable.Select when the source is IQueryable, preserving query composition and enabling async operations like ToListAsync() in Entity Framework Core. ([Issue #3782](https://github.com/dotnet/fsharp/issues/3782), [Issue #15133](https://github.com/dotnet/fsharp/issues/15133))
 * Fix EvaluateQuotation to handle Sequential expressions, void method calls (unit return), and other patterns that were previously throwing NotSupportedException. Also properly handles unit-returning expressions by using Action delegates instead of Func delegates. ([Issue #19099](https://github.com/dotnet/fsharp/issues/19099))
 * Fix query conditionals without else branch (if-then only) that were causing type mismatch errors. Now properly extracts element type from IQueryable for creating empty sequences. ([Issue #3445](https://github.com/dotnet/fsharp/issues/3445))
+* Fix `Seq.empty` rendering as `"EmptyEnumerable"` in serializers by delegating to `System.Linq.Enumerable.Empty<'T>()` instead of using a custom DU type. ([Issue #17864](https://github.com/dotnet/fsharp/issues/17864), [PR #19317](https://github.com/dotnet/fsharp/pull/19317))
+* Ensure culture-independent parsing of .NET-style interpolated string holes. ([Issue #19367](https://github.com/dotnet/fsharp/issues/19367), [PR #19370](https://github.com/dotnet/fsharp/pull/19370))
 
 ### Added
 

docs/release-notes/.Language/preview.md

@@ -1,5 +1,6 @@
 ### Added
 
+* Warn (FS3884) when a function or delegate value is used as an interpolated string argument, since it will be formatted via `ToString` rather than being applied. ([PR #19289](https://github.com/dotnet/fsharp/pull/19289))
 * Added `MethodOverloadsCache` language feature (preview) that caches overload resolution results for repeated method calls, significantly improving compilation performance. ([PR #19072](https://github.com/dotnet/fsharp/pull/19072))
 
 ### Fixed

docs/release-notes/.VisualStudio/18.vNext.md

@@ -6,3 +6,5 @@
 * Improve static compilation of state machines. ([PR #19297](https://github.com/dotnet/fsharp/pull/19297))
 
 ### Changed
+
+* Rename "inline hints" to "inlay hints" in VS options for consistency with industry terminology. ([PR #19318](https://github.com/dotnet/fsharp/pull/19318))