Skip to content

Commit 3ad8d7f

Browse files
committed
Address feedback
1 parent 1b3c9aa commit 3ad8d7f

4 files changed

Lines changed: 5 additions & 6 deletions

File tree

tools/apput/src/Reporter.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ class Reporter
2020
/// <param name="form">The report form (standalone or nested).</param>
2121
/// <param name="doc">An existing <see cref="MarkdownDocument"/> to append to, or <c>null</c> to create a new one.</param>
2222
/// <param name="outputFile">Path to write the report file, or <c>null</c> to write to the console.</param>
23-
public static void Report (IAspect aspect, bool plainTextRendering, ReportForm form = ReportForm.Standalone, MarkdownDocument? doc = null, string? outputFile = null)
23+
public static void Report (IAspect aspect, bool plainTextRendering, ReportForm form = ReportForm.Standalone, MarkdownDocument? doc = null, string? outputFile = null, uint sectionLevel = 1)
2424
{
2525
Type aspectType = aspect.GetType ();
2626

@@ -46,7 +46,7 @@ public static void Report (IAspect aspect, bool plainTextRendering, ReportForm f
4646
throw new InvalidOperationException ($"Internal error: failed to instantiate reporter for type '{aspectType}'");
4747
}
4848

49-
reporter.Report (form);
49+
reporter.Report (form, sectionLevel);
5050
} finally {
5151
// Write report only when we're not nested
5252
if (doc == null) {

tools/apput/src/Reporters/BaseReporter.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ protected void AddNativeArchDesc (ICollection<NativeArchitecture> arches)
113113
}
114114

115115
var architectures = new List<string> ();
116-
foreach (AndroidTargetArch arch in arches) {
116+
foreach (NativeArchitecture arch in arches) {
117117
architectures.Add (arch.ToString ());
118118
}
119119

tools/apput/src/cli/ArchitectureName.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ public static ICollection<NativeArchitecture> ParseList (string v)
7676
break;
7777
}
7878

79-
if (NameMap.TryGetValue (a, out NativeArchitecture arch)) {
79+
if (!NameMap.TryGetValue (a, out NativeArchitecture arch)) {
8080
Log.Warning ($"Unrecognized architecture name '{a}', ignoring.");
8181
continue;
8282
}

tools/apput/src/cli/BaseProgramCommand.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,7 @@ public override int Invoke (IEnumerable<string> args)
5353
return 1;
5454
}
5555

56-
DoInvoke (rest);
57-
return 0;
56+
return DoInvoke (rest);
5857
}
5958

6059
/// <summary>

0 commit comments

Comments
 (0)