-
Notifications
You must be signed in to change notification settings - Fork 330
Move package compatibility app to tools and add robust test coverage #4242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
paulmedynski
wants to merge
7
commits into
main
Choose a base branch
from
dev/paul/auth-app
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
ee71d9e
Add Internal.Logging and Extensions.Abstractions version support to A…
paulmedynski e1ba063
Move AzureAuthentication app to tools/PackageCompatibility and rename
paulmedynski 94b4537
Refine PackageCompatibility package version reporting and docs
paulmedynski 6dccb40
- Moved this app from doc/apps to tools/ which seems like a better fit.
paulmedynski 9241684
Removed unused Azure.Core package version.
paulmedynski 458777a
Address Copilot review comments on PR 4242
paulmedynski ba7bbbb
Added explanation of why this tool is useful, and how it differs from…
paulmedynski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
|
|
||
| <!-- We purposely do not include any parent Directory.Packages.props files. --> | ||
|
|
||
| <PropertyGroup> | ||
| <!-- Use the following package versions if not supplied. --> | ||
| <AbstractionsVersion>1.0.0</AbstractionsVersion> | ||
| <AkvProviderVersion>7.0.0</AkvProviderVersion> | ||
| <LoggingVersion>1.0.0</LoggingVersion> | ||
| <SqlClientVersion>7.0.1</SqlClientVersion> | ||
| <SqlServerVersion>1.0.0</SqlServerVersion> | ||
|
|
||
| <!-- We omit referencing the Azure package entirely by default. --> | ||
| </PropertyGroup> | ||
|
|
||
| <!-- SqlClient Packages --> | ||
| <ItemGroup> | ||
| <!-- | ||
| Normal apps wouldn't explicitly reference these 2 packages, but we do here to force the | ||
| desired versions. This helps detect version conflicts. | ||
| --> | ||
| <PackageVersion Include="Microsoft.Data.SqlClient.Extensions.Abstractions" Version="$(AbstractionsVersion)" /> | ||
| <PackageVersion Include="Microsoft.Data.SqlClient.Internal.Logging" Version="$(LoggingVersion)" /> | ||
|
|
||
| <!-- These are normal references for apps. --> | ||
| <PackageVersion Include="Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider" Version="$(AkvProviderVersion)" /> | ||
| <PackageVersion Include="Microsoft.Data.SqlClient" Version="$(SqlClientVersion)" /> | ||
| <PackageVersion Include="Microsoft.SqlServer.Server" Version="$(SqlServerVersion)" /> | ||
|
|
||
| <!-- Declare a version for the Azure package if one was specified. --> | ||
| <PackageVersion | ||
| Include="Microsoft.Data.SqlClient.Extensions.Azure" | ||
| Version="$(AzureVersion)" | ||
| Condition="'$(AzureVersion)' != ''" /> | ||
| </ItemGroup> | ||
|
|
||
| <!-- Other Packages --> | ||
| <ItemGroup> | ||
| <PackageVersion Include="System.CommandLine" Version="2.0.6" /> | ||
| <PackageVersion Include="xunit.v3" Version="4.0.0-pre.81" /> | ||
| </ItemGroup> | ||
|
|
||
| </Project> |
File renamed without changes.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Markdown structure:
## Test Documentation Requirementsis currently the same heading level as## Writing Tests, so it renders as a sibling section rather than a subsection. Consider changing it to### Test Documentation Requirements(and adjusting subsequent headings accordingly) so the new guidance is clearly nested under "Writing Tests".