Description
Public interfaces ContentletAPI, ContentletAPIPreHook, ContentletAPIPostHook, and ContentletAPIInterceptor currently reference ES-specific types (ESSearchResults, SearchCriteria, SearchResponse). This blocks Phase 3 because in an OS-only environment these types cannot be instantiated.
Priority: Blocking Phase 3
Gate: dotEvergreen R7 cutover (~Aug 18) — deprecated signatures must remain until then
Files
| File |
ES types to remove |
Replacement |
ContentletAPI.java |
ESSearchResults, SearchCriteria |
Remove deprecated esSearch/esSearchRaw signatures |
ContentletAPIPreHook.java |
SearchCriteria parameter |
Vendor-neutral SearchQuery |
ContentletAPIPostHook.java |
SearchCriteria parameter |
Vendor-neutral SearchQuery |
ContentletAPIInterceptor.java |
SearchResponse, ESSearchResults, SearchCriteria |
ContentSearchResults<T>, SearchQuery |
Checklist
Acceptance Criteria
- Zero
org.elasticsearch.* or com.dotcms.content.elasticsearch.* imports in all four files
- All existing ContentletAPI hook implementations compile without modification
- Integration tests pass
Description
Public interfaces
ContentletAPI,ContentletAPIPreHook,ContentletAPIPostHook, andContentletAPIInterceptorcurrently reference ES-specific types (ESSearchResults,SearchCriteria,SearchResponse). This blocks Phase 3 because in an OS-only environment these types cannot be instantiated.Priority: Blocking Phase 3
Gate: dotEvergreen R7 cutover (~Aug 18) — deprecated signatures must remain until then
Files
ContentletAPI.javaESSearchResults,SearchCriteriaesSearch/esSearchRawsignaturesContentletAPIPreHook.javaSearchCriteriaparameterSearchQueryContentletAPIPostHook.javaSearchCriteriaparameterSearchQueryContentletAPIInterceptor.javaSearchResponse,ESSearchResults,SearchCriteriaContentSearchResults<T>,SearchQueryChecklist
esSearch/esSearchRawsignatures fromContentletAPIESSearchResultsandSearchCriteriaimports fromContentletAPISearchCriteriaparameter inContentletAPIPreHookto neutral typeSearchCriteriaparameter inContentletAPIPostHookto neutral typeSearchResponse,ESSearchResults,SearchCriteriainContentletAPIInterceptorwithContentSearchResults<T>andSearchQueryAcceptance Criteria
org.elasticsearch.*orcom.dotcms.content.elasticsearch.*imports in all four files