Add startup tasks to put Tags and Plugins (Angular) portlets in menu

[hmoreras]

Description

Implement two runonce startup tasks that wire up Angular portlets into the admin menu as part of the migration away from legacy JSP portlets.

---

Task 1 — Tags portlet menu migration

Ensure the Angular Tags portlet (id tags, route /tags) is present in the admin menu and the legacy Tags portlet (tags-legacy) is removed from all layouts. This was previously implemented in `Task260211AddTagsNewPortletToMenu` and removed from its original PR so it can be delivered in a dedicated PR.

The task should:

• Run when: Any layout still has `tags-legacy`, or no layout has `tags`, or any layout has the old id `tags-new`.
• On run:
  1. Migrate layout entries from portlet id `tags-new` to `tags` (portlet was renamed).
  2. Remove `tags-legacy` from all layouts (so it does not appear in the sidebar).
  3. If `tags` is still not in any layout after migration, add it to the "Content Types" layout (or fallback to a layout that contained `tags-legacy`).
  4. Clear layout cache (CacheLocator.getLayoutCache().clearCache()).

---

Task 2 — Plugins portlet menu addition

Ensure the Angular Plugins portlet (id plugins, route /plugins) appears in the admin menu right after the existing legacy dynamic-plugins JSP portlet (OSGI Manager). Both portlets live in the same menu group.

The task should:

• Run when: The plugins portlet is not present in any layout.
• On run:
  1. Find the layout containing dynamic-plugins.
  2. Shift all portlets in that layout with portlet_order ≥ dynamic-plugins.portlet_order + 1 up by 1 to make room.
  3. Insert plugins with portlet_order = dynamic-plugins.portlet_order + 1.
  4. Clear layout cache (CacheLocator.getLayoutCache().clearCache()).

---

Acceptance Criteria

Tags task

• New runonce task class in dotCMS/src/main/java/com/dotmarketing/startup/runonce/ (e.g. Task260211AddTagsNewPortletToMenu, following current date-based naming).
• forceRun() returns true when: tags-legacy is in any layout, or tags is in zero layouts, or tags-new is in any layout.
• executeUpgrade() migrates tags-new → tags, removes tags-legacy from all layouts, adds tags to "Content Types" layout (or fallback) if missing, then clears layout cache.
• Uses PortletID.TAGS and PortletID.TAGS_LEGACY from com.dotmarketing.util.PortletID.
• Exception handling: forceRun() catches Exception (not just DotDataException) because DotConnect.getInt() can throw DotRuntimeException.
• Registered in TaskLocatorUtil.getStartupRunOnceTaskClasses().

Plugins task

• New runonce task class (e.g. Task260318AddPluginsPortletToMenu, following current date-based naming).
• forceRun() returns true when plugins portlet is absent from all layouts (COUNT = 0); catches Exception.
• executeUpgrade() finds the layout containing dynamic-plugins, shifts subsequent portlets' portlet_order up by 1, inserts plugins immediately after dynamic-plugins, then clears layout cache.
• If dynamic-plugins is not found in any layout, logs an error and exits gracefully without inserting.
• Uses PortletID.DYNAMIC_PLUGINS and PortletID.PLUGINS from com.dotmarketing.util.PortletID.
  • Note: PLUGINS enum entry must be added to PortletID.java (resolves to "plugins" by default naming convention).
• Registered in TaskLocatorUtil.getStartupRunOnceTaskClasses().

Both tasks

• Logging via Logger; no System.out.
• Idempotent: running more than once does not duplicate entries or corrupt layout order.
• Follow patterns from existing tasks in the same package (see Task260206AddUsagePortletToMenu.java as reference).

---

Priority

Medium

---

Additional Context

Already done in the companion PR (issue-34732):

• portlet.xml — plugins portlet entry added with PortletController class (Angular).
• PortletID.java — PLUGINS enum entry added.
• app.routes.ts — /plugins route now has canActivate: [MenuGuardService].
• portlet.xml already has tags and tags-legacy entries.

Startup task reference: Task260206AddUsagePortletToMenu.java — same pattern for layout lookup, cms_layouts_portlets insert, and cache clear.

Tables: cms_layout, cms_layouts_portlets. Columns: layout_id, portlet_id, portlet_order, id (UUID for new rows).

Insert pattern:

INSERT INTO cms_layouts_portlets(id, layout_id, portlet_id, portlet_order) VALUES (?, ?, ?, ?)

Use UUIDUtil.uuid() for id.

Shift pattern (for Plugins task):

UPDATE cms_layouts_portlets SET portlet_order = portlet_order + 1
WHERE layout_id = ? AND portlet_order >= ?

This work was split out from the PR that adds the Angular portlets (issue-34732) so startup tasks can be reviewed and merged in a dedicated PR.

[hmoreras]

Implementation Update from PR issue-34732

During the development of the Angular Plugins portlet (PR for issue-34732), the design for Task 2 evolved. Here are the technical findings for whoever implements this task.

---

Design Decision: both portlets visible in the menu

The original spec said to add plugins (Angular) right after dynamic-plugins (JSP), keeping both in the menu. The implementation went a step further:

• dynamic-plugins was renamed to plugins-legacy in portlet.xml — so the JSP portlet gets a cleaner label ("Plugins Legacy") and the portlet ID is explicit about its role.
• plugins (Angular, PortletController) keeps the primary slot.
• Both entries appear in the sidebar: Plugins (Angular) and Plugins Legacy (JSP/OSGI Manager).

---

Already done in companion PR (issue-34732)

These changes are already committed and should be treated as pre-conditions for the startup task:

File	Change
portlet.xml	dynamic-plugins portlet renamed to plugins-legacy (same view-jsp); Angular plugins portlet already registered with PortletController
PortletID.java	PLUGINS_LEGACY("plugins-legacy") added
Language.properties	com.dotcms.repackage.javax.portlet.title.plugins=Plugins and ...plugins-legacy=Plugins Legacy added

---

Updated spec for the startup task

Class name suggestion: Task260319MigratePluginsPortletInMenu

forceRun() — return true when:

• Any layout still has portlet_id = 'dynamic-plugins' (old id, needs migration), OR
• plugins (Angular) is absent from all layouts (COUNT = 0)

executeUpgrade() — for each row where portlet_id = 'dynamic-plugins':

1. UPDATE cms_layouts_portlets SET portlet_id = 'plugins' WHERE id = ? — Angular takes the existing slot.
2. UPDATE cms_layouts_portlets SET portlet_order = portlet_order + 1 WHERE layout_id = ? AND portlet_order > ? — shift everything after to make room.
3. INSERT INTO cms_layouts_portlets(id, layout_id, portlet_id, portlet_order) VALUES (uuid, layoutId, 'plugins-legacy', order+1) — insert Legacy right after Angular.
4. Skip insert if plugins-legacy is already in that layout (idempotency guard).
5. CacheLocator.getLayoutCache().clearCache()

Use PortletID.PLUGINS and PortletID.PLUGINS_LEGACY (both already in the enum).

If no dynamic-plugins rows are found (fresh install): log and exit — Angular portlet not in any layout will be handled separately or added manually.

---

Reference implementation

The full working implementation was prototyped and then reverted from issue-34732 so it can land in a dedicated PR (this issue). The code is available in the conversation history for that branch. Follow Task260206AddUsagePortletToMenu.java for the insert/cache-clear pattern and Task241015ReplaceLanguagesWithLocalesPortlet.java for the rename + insert together pattern.

[hmoreras]

work in PR: #34957

[hmoreras]

only the Plugins UT was created .