Sync SQL Server ODBC constants between Python and C++

- Add SQL_SS_XML (-152) constant to Python constants.py
  (was incorrectly using SQL_XML = 241)
- Add SQL_SS_TIME2 (-154) constant for SQL Server TIME(n) type
- Update cursor type map to use SQL_SS_XML and add SQL_SS_TIME2 mapping
- Add sync comment in C++ to prevent future constant drift

Constants verified against Microsoft Learn ODBC documentation:
- SQL_SS_TIME2: -154 (SQLNCLI.h)
- SQL_SS_TIMESTAMPOFFSET: -155 (SQLNCLI.h)
- SQL_SS_XML: -152 (SQL Server ODBC driver)
- SQL_SS_UDT: -151 (SQL Server ODBC driver)

Addresses Copilot review feedback on PR microsoft#355

Author: dlevy-msft-sql

mssql_python/constants.py

@@ -115,7 +115,9 @@ class ConstantsDDBC(Enum):
     SQL_FETCH_RELATIVE = 6
     SQL_FETCH_BOOKMARK = 8
     SQL_DATETIMEOFFSET = -155
+    SQL_SS_TIME2 = -154  # SQL Server TIME(n) type
     SQL_SS_UDT = -151  # SQL Server User-Defined Types (geometry, geography, hierarchyid)
+    SQL_SS_XML = -152  # SQL Server XML type
     SQL_C_SS_TIMESTAMPOFFSET = 0x4001
     SQL_SCOPE_CURROW = 0
     SQL_BEST_ROWID = 1

mssql_python/cursor.py

@@ -96,6 +96,7 @@ def _get_type_map(cls):
                 ddbc_sql_const.SQL_DATE.value: datetime.date,
                 ddbc_sql_const.SQL_TIMESTAMP.value: datetime.datetime,
                 ddbc_sql_const.SQL_TIME.value: datetime.time,
+                ddbc_sql_const.SQL_SS_TIME2.value: datetime.time,  # SQL Server TIME(n)
                 ddbc_sql_const.SQL_BIT.value: bool,
                 ddbc_sql_const.SQL_TINYINT.value: int,
                 ddbc_sql_const.SQL_SMALLINT.value: int,
@@ -105,7 +106,7 @@ def _get_type_map(cls):
                 ddbc_sql_const.SQL_LONGVARBINARY.value: bytes,
                 ddbc_sql_const.SQL_GUID.value: uuid.UUID,
                 ddbc_sql_const.SQL_SS_UDT.value: bytes,
-                ddbc_sql_const.SQL_XML.value: str,
+                ddbc_sql_const.SQL_SS_XML.value: str,  # SQL Server XML type (-152)
                 ddbc_sql_const.SQL_DATETIME2.value: datetime.datetime,
                 ddbc_sql_const.SQL_SMALLDATETIME.value: datetime.datetime,
                 ddbc_sql_const.SQL_DATETIMEOFFSET.value: datetime.datetime,

mssql_python/pybind/ddbc_bindings.cpp

@@ -31,6 +31,10 @@
 #define SQL_DATETIME2 (42)
 #define SQL_SMALLDATETIME (58)
 
+// NOTE: The following SQL Server-specific type constants MUST stay in sync with
+// the corresponding values in mssql_python/constants.py (ConstantsDDBC enum):
+// SQL_SS_TIME2, SQL_SS_XML, SQL_SS_UDT, SQL_DATETIME2, SQL_SMALLDATETIME, SQL_DATETIMEOFFSET
+
 #define STRINGIFY_FOR_CASE(x)                                                                      \
     case x:                                                                                        \
         return #x