[FTBS] latest python-gmp 0.5.0 from PyPi fails to build because of a check for a non-existent GIT version

[Corin-EU]

This is on openSUSE Leap 15.6 with locally installed Python 3.12 and locally installed
pip==26.0.1
meson-python==0.19.0
├── meson [required: >=1.2.3, installed: 1.9.1]
├── packaging [required: >=23.2, installed: 26.0]
└── pyproject-metadata [required: >=0.9.0, installed: 0.11.0]
└── packaging [required: >=23.2, installed: 26.0]

After downloading the source code archive from PyPi, unpacking, and trying to instal with pip --

   Using pip 26.0.1 from /usr/local/lib/python3.12/site-packages/pip (python 3.12)
   Processing ./.
   Running command Preparing metadata (pyproject.toml)
    + meson setup /usr/src/build/python_gmp-0.5.0 /usr/src/build/python_gmp-0.5.0/.mesonpy-wea7z76c -Dbuildtype=release -Db_ndebug=if-release -Db_vscrt=md --native-file=/usr/src/build/python_gmp-0.5.0/.mesonpy-wea7z76c/meson-python-native-file.ini
   The Meson build system
   Version: 1.9.1
   Source dir: /usr/src/build/python_gmp-0.5.0
  Build dir: /usr/src/build/python_gmp-0.5.0/.mesonpy-wea7z76c
  Build type: native build

 ../meson.build:2:17: ERROR: Command `/usr/bin/python scripts/gitversion.py` failed with status -6.

The meson.build file has the entry

            version: run_command('python', 'scripts/gitversion.py',
                         check: true).stdout().strip(),

The script gitversion.py tries to get the source code version of the module as if the source code was in a GIT repository which is not a valid method for a PyPi source code archive.

There should be a check on whether or not the source code is a GIT archive repository and if not, get the version from the PKG-INFO file or some other source code version specifying file.

[skirpichev]

I believe this issue will be fixed by #328 and I appreciate if you can confirm this or/and review the pr.

After merging I'll make also v0.5.1 release.

[Corin-EU]

Thank you for your very speedy action in addressing this issue.

Your solution appears to use a "non-standard" module to determine the version, re

          scripts/git-version.py        line 50:      from version import version

An sdist of the "version" module is not available on PyPi and the 0.1.1 version of 2014 from Github does not build with Python 3.12 and setuptools 82.0.1

      Using pip 26.0.1 from /usr/local/lib/python3.12/site-packages/pip (python 3.12)
      Processing ./.
      Running command Preparing metadata (pyproject.toml)
      /usr/src/build/version-0.1.1/version.py:20: SyntaxWarning: invalid escape sequence '\d'
'(\d+)\.(\d+)\.(\d+)'  # minor, major, patch
      /usr/src/build/version-0.1.1/version.py:21: SyntaxWarning: invalid escape sequence '\.'
'(-[0-9A-Za-z-\.]+)?'  # pre-release
     /usr/src/build/version-0.1.1/version.py:22: SyntaxWarning: invalid escape sequence '\+'
'(\+[0-9A-Za-z-\.]+)?'  # build
    Traceback (most recent call last):
    File "/usr/local/lib/python3.12/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 389, in <module>
  main()
    File "/usr/local/lib/python3.12/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 373, in main
    json_out["return_val"] = hook(**hook_input["kwargs"])
                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    File "/usr/local/lib/python3.12/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 175, in prepare_metadata_for_build_wheel
  return hook(metadata_directory, config_settings)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/site-packages/setuptools/build_meta.py", line 380, in prepare_metadata_for_build_wheel
  self.run_setup()
File "/usr/local/lib/python3.12/site-packages/setuptools/build_meta.py", line 520, in run_setup
          super().run_setup(setup_script=setup_script)
File "/usr/local/lib/python3.12/site-packages/setuptools/build_meta.py", line 317, in run_setup
          exec(code, locals())
File "<string>", line 4, in <module>
File "/usr/src/build/version-0.1.1/version.py", line 2, in <module>
          from itertools import izip_longest
   ImportError: cannot import name 'izip_longest' from 'itertools' (unknown location). Did you mean:               'zip_longest'?
        error: subprocess-exited-with-error

There are two PR requests of age 10 and 8 years respectively on the "version"git repository to address these problems but no action has ever been taken so it appears that version is unmaintained and dead.

My suggestion is that rather than using the "non-standard" unmaintained version module (adding yet another dependency to the overall python installed modules environment, use a standard, up to date, mainained PyPi modue to get the version eg semantic-version or versioneer.

[skirpichev]

Your solution appears to use a "non-standard" module to determine the version.

Yes, it's just a file in the sdist, which kept the version number, created by the build backend.

An sdist of the "version" module is not available on PyPi and the 0.1.1 version of 2014 from Github does not build with Python 3.12 and setuptools 82.0.1

Are you worry that the module name will clash with some ancient package on the PyPI? I doubt it's a real problem, though using a private name (like _version.py) will be clearer.

use a standard, up to date, mainained PyPi modue to get the version eg semantic-version or versioneer.

This project used the setuptools-scm before. The versioneer seems better, as it not introduces new build-time dependencies. But it's still rather a complex solution and I adopted numpy-like approach for same reasons: numpy/numpy#23981 (comment).

[Corin-EU]

Sorry, did I misinterpret the meaning of "import version" ?

I thought it was trying to import the external obsolete version module, hence my attempt at trying to install it.

If it is an internal file, then calling it something like _version would indeed avoid confusion.

If that works satisfactorily, then there would be no need to pull in another dependency on some external module such as semantic-version or versioneer..

An idea -- rather than just naming the file " _version.py", how about the more descriptive "sdist_version.py" or "version_sdist.py" or instead of "sdist", "source" as in "source_version.py"?

That would make it clear as to which version of what the file was referring.

[skirpichev]

In the new stable release this issue should be fixed:
https://pypi.org/project/python-gmp/0.5.1/