Clean up print statements and other minor items flagged by @coderabbitai

Author: rlskoeser

src/undate/converters/calendars/islamic/converter.py

@@ -76,9 +76,7 @@ def to_gregorian(self, year: int, month: int, day: int) -> tuple[int, int, int]:
         """Convert a Hijri date, specified by year, month, and day,
         to the Gregorian equivalent date. Returns a tuple of year, month, day.
         """
-        print(
-            f"islamic.to_gregorian(year={year}, month={month}, day={day}) = {islamic.to_gregorian(year, month, day)}"
-        )
+        # NOTE: this results in weird numbers for months when year gets sufficiently high
         return islamic.to_gregorian(year, month, day)
 
     def parse(self, value: str) -> Union[Undate, UndateInterval]:

src/undate/undate.py

@@ -39,8 +39,8 @@ def get_converter(calendar) -> BaseCalendarConverter:
             converter_cls = BaseDateConverter.available_converters()[
                 calendar.value.title()
             ]
-        except KeyError:
-            raise ValueError(f"Unknown calendar '{calendar}'")
+        except KeyError as err:
+            raise ValueError(f"Unknown calendar '{calendar}'") from err
         if not issubclass(converter_cls, BaseCalendarConverter):
             raise ValueError(
                 f"Requested converter '{calendar.value.title()}' is not a CalendarConverter"
@@ -197,9 +197,6 @@ def calculate_earliest_latest(self, year, month, day):
         self.earliest = Date(
             *self.calendar_converter.to_gregorian(min_year, earliest_month, min_day)
         )
-        print(
-            f"initializing latest, year={max_year} month={latest_month} day={max_day}"
-        )
         self.latest = Date(
             *self.calendar_converter.to_gregorian(max_year, latest_month, max_day)
         )
@@ -495,13 +492,12 @@ def possible_years(self) -> list[int] | range:
             # convert place to 1, 10, 100, 1000, etc.
             step = 10 ** (missing_digit_place - 1)
             return range(earliest_year, latest_year + 1, step)
-        else:  # year is fully unknown
-            # returning range from min year to max year is not useful in any scenario!
-            raise ValueError(
-                "Possible years cannot be returned for completely unknown year"
-            )
 
-        return []  # shouldn't get here, but mypy complains
+        # otherwise, year is fully unknown
+        # returning range from min year to max year is not useful in any scenario!
+        raise ValueError(
+            "Possible years cannot be returned for completely unknown year"
+        )
 
     @property
     def representative_years(self) -> list[int]:

tests/test_undate.py

@@ -407,7 +407,7 @@ def test_possible_years(self):
         with pytest.raises(
             ValueError, match="cannot be returned for completely unknown year"
         ):
-            Undate("XXXX").possible_years
+            assert Undate("XXXX").possible_years
 
     def test_representative_years(self):
         # single year is returned as is