Skip to content

Commit 0abff70

Browse files
committed
Disable leak detection and remove early ASAN testing
The leak report becomes too large for CI. Someone needs to fix it. Signed-off-by: Joseph Schuchart <joseph.schuchart@stonybrook.edu>
1 parent 203970a commit 0abff70

1 file changed

Lines changed: 7 additions & 26 deletions

File tree

.github/workflows/ompi_mpi4py.yaml

Lines changed: 7 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -131,29 +131,6 @@ jobs:
131131
env:
132132
CFLAGS: "-O0"
133133

134-
###
135-
# Copied here, remove once working
136-
###
137-
- name: Setting up ASAN environment
138-
run: |
139-
echo LD_PRELOAD=/usr/lib/x86_64-linux-gnu/libasan.so.8 >> $GITHUB_ENV
140-
echo ASAN_OPTIONS=detect_odr_violation=0,abort_on_error=1 >> $GITHUB_ENV
141-
echo LSAN_OPTIONS=detect_leaks=1,exitcode=0 >> $GITHUB_ENV
142-
echo OMPI_MCA_memory=^patcher >> $GITHUB_ENV
143-
144-
- name: Test mpi4py ASAN (np=1)
145-
run: mpiexec -n 1 python test/main.py -v -x TestExcErrhandlerNull
146-
if: ${{ true }}
147-
timeout-minutes: 10
148-
149-
- name: Test mpi4py ASAN (np=4)
150-
run: mpiexec -n 4 python test/main.py -v -f -x TestExcErrhandlerNull
151-
if: ${{ true }}
152-
timeout-minutes: 10
153-
###
154-
# End of copy
155-
###
156-
157134
- name: Test mpi4py (singleton)
158135
run: python test/main.py -v -x TestExcErrhandlerNull
159136
if: ${{ true }}
@@ -185,12 +162,16 @@ jobs:
185162
timeout-minutes: 10
186163

187164
- name: Setting up ASAN environment
188-
# we need to disable the memory patcher for ASAN to work properly,
189-
# see https://github.com/open-mpi/ompi/issues/12819
165+
# LD_PRELOAD is needed to make sure ASAN is the first thing loaded
166+
# as it will otherwise complain
167+
# Leak detection is currently disabled because of the size of the report.
168+
# The patcher is disabled because ASAN fails if code mmaps data at fixed
169+
# memory addresses, see https://github.com/open-mpi/ompi/issues/12819
170+
# ODR violation detection is disabled until #13469 is fixed
190171
run: |
191172
echo LD_PRELOAD=/usr/lib/x86_64-linux-gnu/libasan.so.8 >> $GITHUB_ENV
192173
echo ASAN_OPTIONS=detect_odr_violation=0,abort_on_error=1 >> $GITHUB_ENV
193-
echo LSAN_OPTIONS=detect_leaks=1,exitcode=0 >> $GITHUB_ENV
174+
echo LSAN_OPTIONS=detect_leaks=0,exitcode=0 >> $GITHUB_ENV
194175
echo OMPI_MCA_memory=^patcher >> $GITHUB_ENV
195176
196177
- name: Test mpi4py ASAN (np=1)

0 commit comments

Comments
 (0)