Generated types are incompatible with ECMAScript modules

[benesjan]

Hello,
when having "module": "NodeNext" in tsconfig.json, I get the following error:

There doesn't seem to be an option to make typescript generate imports with file extensions. When I manually modify the typescript files and the extensions (.js or /index.js) to all the imports the issue disappears. Is there a way to enable this? If not would be great to have the support.

The repository I am working on is open-source so I can send a link if somebody would like to reproduce it.

Thank you

[silasdavis]

I have implemented support for this here: #799

[benesjan]

@silasdavis Thank you! 👍

[pablomendezroyo]

This should not be closed as long as the PR is still opened

[krzkaczor]

Merged as: #840

[pablomendezroyo]

Im still running into the same issue: the .js extension not been added even with the flag --node16-modules flag provided

Typechain command

"typechain": "typechain --node16-modules --target ethers-v6 --out-dir ./src/typechain './truffle/contracts_build/contracts*/*.json'",

Multiple errors with the format:

src/typechain/index.ts:92:32 - error TS2835: Relative import paths need explicit file extensions in EcmaScript imports when '--moduleResolution' is 'node16' or 'nodenext'. Did you mean './factories/contracts_v0.5/Owned__factory.js'?

92 export { Owned__factory } from "./factories/contracts_v0.5/Owned__factory";

Versions:

   "@typechain/ethers-v6": "^0.4.0",
   "typechain": "^8.2.0",

[pablomendezroyo]

For those running into this issue, I just execute a js script that add the .js extension to relative imports right after the typechain command as follows

&& node addExtensionJs.js

The script command: https://github.com/dappnode/toolkit/blob/main/addExtensionJs.js

[jmrossy]

@krzkaczor The output when --node16-modules is enabled is almost correct but is still not valid ESM code. The output includes both direct exports and rolled up exports using the * as Foo syntax, which imports from barrel files that do not include the needed file extension. See here for an example: https://github.com/dethcrypto/TypeChain/pull/840/files#diff-a13cd542099b350a17167268ac727e5d459fae33143fd0a1baf4cbb77f191f51R5

The line should be export * as factories from "./factories.js", or preferably excluded altogether.

Is there a way to disable the * as exports which are unnecessary and undesirable as they reduce the effectiveness of tree shaking?

I see this is the same issue that was raised here and was supposedly fixed but I'm still seeing it use the latest typechain version

Edit: I've found the problem and submitted a PR to fix here: #898