Removed EVSS:PPIU Specs

[RachalCassity]

Keep your PR as a Draft until it's ready for Platform review. A PR is ready for Platform review when it has a teammate approval and tests, linting, and settings checks pass CI. See these tips on how to avoid common delays in getting your PR merged.

Summary

This PR removes deprecated testing infrastructure for the EVSS (External Veteran-facing Services) PPIU (Payment Information Update) service. The change involves cleaning up test files, factories, VCR cassettes, and related code that's no longer needed.

EVSS::PPIU configuration will be removed after this pull request is merged.

Related issue(s)

• Deprecate EVSS PPIU - [Platform] Part 2 (final vets-api cleanup) va.gov-team#113898

Testing done

• New code is covered by unit tests
• Describe what the old behavior was prior to the change
• Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
• If this work is behind a flipper:
  • Tests need to be written for both the flipper on and flipper off scenarios. Docs.
  • What is the testing plan for rolling out the feature?

Screenshots

Note: Optional

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

[va-vsp-bot]

Error: A file (or its parent directories) was deleted but its reference still exists in CODEOWNERS. Please update the .github/CODEOWNERS file and delete the entry for the Offending file: spec/lib/evss/ppiu

[va-vsp-bot]

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: app/models/form_profiles/va_0994.rb

[va-vsp-bot]

Error: A file (or its parent directories) was deleted but its reference still exists in CODEOWNERS. Please update the .github/CODEOWNERS file and delete the entry for the Offending file: spec/lib/evss/ppiu

[va-vsp-bot]

Error: A file (or its parent directories) was deleted but its reference still exists in CODEOWNERS. Please update the .github/CODEOWNERS file and delete the entry for the Offending file: spec/lib/evss/ppiu

[va-vsp-bot]

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: app/models/form_profiles/va_0994.rb

[va-vsp-bot]

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: app/models/form_profiles/va_0994.rb

[va-vsp-bot]

Error: A file (or its parent directories) was deleted but its reference still exists in CODEOWNERS. Please update the .github/CODEOWNERS file and delete the entry for the Offending file: spec/lib/evss/ppiu

[va-vsp-bot]

Error: A file (or its parent directories) was deleted but its reference still exists in CODEOWNERS. Please update the .github/CODEOWNERS file and delete the entry for the Offending file: spec/lib/evss/ppiu

[va-vsp-bot]

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: app/models/form_profiles/va_0994.rb

[va-vsp-bot]

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: app/models/form_profiles/va_526ez.rb

[Copilot]

Pull request overview

This PR removes deprecated EVSS::PPIU testing infrastructure as part of the phased deprecation of the EVSS PPIU service. The changes remove VCR cassettes, test specs, factories, and update production code that referenced the deprecated service.

Key changes:

• Removed all EVSS::PPIU-related VCR test cassettes for both EVSS and mobile endpoints
• Deleted test specifications for EVSS::PPIU service, payment information, and payment account models
• Removed FactoryBot factories for PPIU payment data
• Updated form profile code to remove EVSS::PPIU service dependencies

Reviewed changes

Copilot reviewed 24 out of 24 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
spec/support/vcr_cassettes/mobile/payment_information/*.yml	Removed mobile payment information VCR cassettes (4 files)
spec/support/vcr_cassettes/evss/ppiu/*.yml	Removed EVSS PPIU VCR cassettes (6 files)
spec/lib/evss/ppiu/service_spec.rb	Deleted EVSS::PPIU service test file
spec/lib/evss/ppiu/payment_information_spec.rb	Deleted payment information model test file
spec/lib/evss/ppiu/payment_account_spec.rb	Deleted payment account model test file
spec/lib/disability_compensation/providers/ppiu_direct_deposit/ppiu_provider_spec.rb	Deleted PPIU provider base test file
spec/lib/sentry/event_scrubber_spec.rb	Removed PPIU-specific PII filtering test case
spec/factories/ppiu_payment_information_responses.rb	Deleted PPIU response factory definitions
spec/factories/ppiu_payment_account.rb	Deleted PPIU payment account factory
spec/models/form_profile_spec.rb	Removed PPIU VCR cassette and expected bank account assertions from form 0994 test
modules/mobile/spec/requests/mobile/v1/user_spec.rb	Removed PPIU VCR cassette wrappers from 8 test contexts
modules/mobile/spec/requests/mobile/v0/user_spec.rb	Removed PPIU VCR cassette wrappers from 9 test contexts
app/models/form_profiles/va_0994.rb	Removed EVSS::PPIU service calls but left broken code referencing undefined variable
app/models/form_profiles/va_526ez.rb	Removed unused EVSS::PPIU require statement
config/initializers/inflections.rb	Removed PPIU acronym definition
.github/CODEOWNERS	Removed CODEOWNERS entries for deleted PPIU test files and cassettes

[Copilot]

The variable raw_account is used but never defined. The previous code retrieved this data from EVSS::PPIU::Service, but after removing those lines, the variable is referenced without being set. This will cause a NameError when this method executes.

Looking at similar form profiles like va_10297.rb and va_526ez.rb, this should likely be updated to use the Lighthouse API provider instead, following the pattern:

provider = ApiProviderFactory.call(
  type: ApiProviderFactory::FACTORIES[:ppiu],
  provider: ApiProviderFactory::API_PROVIDER[:lighthouse],
  current_user: user,
  feature_toggle: nil
)
response = provider.get_payment_information
raw_account = response.responses.first&.payment_account

Or if payment information is no longer needed for this form, the entire method should return {} early after the authorization check.

[rjohnson2011]

Looks like you removed raw_account's definition on line 42

[RachalCassity]

@rjohnson2011 I removed the payment code. This form is no longer used in prod. slack thread with team

[RachalCassity]

The team has plans to remove the deprecated 0994 form in the next few sprints.